finos / bot-github-chatops

A Symphony bot that uses ChatOps techniques to allow a firm employee to interact in a compliant manner with GitHub issues and PRs
Apache License 2.0
10 stars 2 forks source link

:new: bot monitoring via jolokia and openshift service/route #36

Closed maoo closed 6 years ago

maoo commented 6 years ago

Still missing livenessProbe and readinessProbe configuration, but at least now we have a URL to monitor the bot:

curl http://bot-github-chatops-dev-jolokia-ssf-dev.b9ad.pro-us-east-1.openshiftapps.com/jolokia/exec/org.symphonyoss.client:type=ClientCheckMBean/isUp | grep '"value":true'
echio $?

I'll send another PR as soon as I figure out openshift probe configuration.

maoo commented 6 years ago

@pmonks - addressed all issues, except the upstream dependency; let's keep this PR open until we can define a dependency to an SJC SNAPSHOT.

ssf-admin commented 6 years ago

@pmonks - I think the PR is ready, fixed readiness and liveness probe. Do we want to wait for SJC 1.1.3 release, or you're ok using the 1.1.3-SNAPSHOT version, at least to merge on dev branch?