Closed maoo closed 6 years ago
@pmonks - addressed all issues, except the upstream dependency; let's keep this PR open until we can define a dependency to an SJC SNAPSHOT.
@pmonks - I think the PR is ready, fixed readiness and liveness probe. Do we want to wait for SJC 1.1.3 release, or you're ok using the 1.1.3-SNAPSHOT version, at least to merge on dev
branch?
Still missing
livenessProbe
andreadinessProbe
configuration, but at least now we have a URL to monitor the bot:I'll send another PR as soon as I figure out openshift probe configuration.