finos / bot-github-chatops

A Symphony bot that uses ChatOps techniques to allow a firm employee to interact in a compliant manner with GitHub issues and PRs
Apache License 2.0
10 stars 2 forks source link

Use tools.cli to parse parameters #48

Closed maoo closed 4 years ago

maoo commented 6 years ago

Feature Request

Description of Problem:

Building new commands with bot-github-chatops implies adding items to the commands.clj file, which currently parses bot input manually.

Potential Solutions:

https://github.com/clojure/tools.cli delivers a similar functionality but for command-line inputs, which isn't a particularly appropriate format for chat-style interactions.

If there's no library that helps parsing the argument input, a simple library could already help keeping the code leaner and easier to extend.

pmonks commented 6 years ago

tools.cli is designed to provide GNU compliant options parsing, which isn't a particularly appropriate format for chat-style interactions.

maoo commented 6 years ago

Thanks for the feedback @pmonks . I'll keep the issue open for future references.

pmonks commented 6 years ago

In that case can I encourage you to rewrite this issue (title & description) as a problem statement, rather than a solution statement?

Job stories (see below) are a good format that help ensure that you're identifying problems rather than solutions.

Job Story Form image

pmonks commented 4 years ago

@maoo any updates on this issue? To my mind this should be closed as invalid, since if we're looking to improve the current simplistic parsing of regular-human-to-computer chat interactions (and it's not clear to me that that's a priority at this point), I'd want to look at NLP approaches, not GNU CLI parsing (which is command-line-user-to-computer).

maoo commented 4 years ago

Closing and marking as invalid , as suggested above.