Closed maoo closed 4 years ago
Thanks @maoo - those steps sound fine to me. The 'User authorization callback URL' at the moment is https://colineberhardt.github.io/cla-bot/
.
I also have a test version of the app:
https://github.com/apps/cla-bot-dev
Which is installed on the following private repo:
https://github.com/ColinEberhardt/clabot-test/
If you provide the URLs described in step (1) above, I'd be happy to test on this first.
One question I do have is about potential AWS access? Would I be able to have read-only access to the S3 bucket that collects the logs? It is interesting to see who is using this bot! It's not a big deal if this isn't possible.
You also need to update the website associated with this project:
Thanks @maoo - those steps sound fine to me. The 'User authorization callback URL' at the moment is https://colineberhardt.github.io/cla-bot/.
Great, so we should update it to https://finos-fdx.github.io/cla-bot/ ; added to the TODO list in #113
I also have a test version of the app: https://github.com/apps/cla-bot-dev Which is installed on the following private repo: https://github.com/ColinEberhardt/clabot-test/
Great, we have that too, I find it quite useful to test new deployments and make sure the bot works properly across all installations; I'm going to grant you access ASAP.
If you provide the URLs described in step (1) above, I'd be happy to test on this first.
The staging bot is deployed on https://dxuz6nf3l6.execute-api.us-east-1.amazonaws.com/staging/cla-check
, the prod on https://7bmwwm2gbd.execute-api.us-east-1.amazonaws.com/prod/cla-check
. You can find the link in the Travis logs, respectively https://travis-ci.org/finos-fdx/cla-bot/builds/509775653
and https://travis-ci.org/finos-fdx/cla-bot/builds/509779545
One question I do have is about potential AWS access? Would I be able to have read-only access to the S3 bucket that collects the logs? It is interesting to see who is using this bot! It's not a big deal if this isn't possible.
I'll grant you access shortly, no problem for me; can you please send me a private message with your Amazon account ID?
You also need to update the website associated with this project
Done.
Hi Mao,
I configured my test GitHub app to use your prod URL:
https://7bmwwm2gbd.execute-api.us-east-1.amazonaws.com/prod/cla-check
However, when I create a PR, I am seeing 502 errors from the above.
I get the same response from the staging URL too.
This is not needed anymore, since finos-fdx got merged into finos GH org. Closing.
As a follow up of issue #113 , the CLA bot application should be migrated to github.com/finos-fdx Organization.
I've tested the process and documented it below, step by step; for each step, a screenshot is attached.
FINOS test github app
from my GitHub user account (maoo
) 2/3. Configured theFINOS test github app
in my GitHub user account and enabled on one repository 4/5. Transferred theFINOS test github app
tofinos-fdx
orgfinos-fdx
org ownerHomepage URL
andWebhook URL
(User authorization callback URL
should not be needed, @ColinEberhardt , can you please confirm?)I didn't receive any notification of the transfer as GitHub App user, which means that current cla-bot users should not be notified of this change either.
I would suggest the following ordered actions:
Homepage URL
andWebhook URL
on thecla-bot
GitHub App and test that everything is still working as expected, using a test repository withcla-bot
app installed (step 7 of the test)cla-bot
app (steps 4, 5 and 6) and monitor test repocla-bot
GitHub App on github.com/finos Organizationfinos-fdx
)Am I missing anything?