search

finos / common-cloud-controls

FINOS Common Cloud Controls
https://www.finos.org/common-cloud-controls-project
Other
26 stars 25 forks source link

Add CODEOWNERS file #181

Closed eddie-knight closed 3 weeks ago

eddie-knight commented 1 month ago

Drafted in coordination with @sshiells-scottlogic as part of #177

eddie-knight commented 3 weeks ago

@TheJuanAndOnly99 I'm not sure the errors here are correct 🤔 Everything in the organization's teams seems to match the entries here, but it's saying two entries don't exist. Perhaps it's just an issue with the renaming not causing the checks to re-run.

WDYT? I'm inclined to merge it since there's no apparent reason for that soft check to fail.

TheJuanAndOnly99 commented 3 weeks ago

@eddie-knight Should be good now. I had to change the CCC team permissions from read to write. Is that what we want?

sshiells-scottlogic commented 3 weeks ago

@sshiells-scottlogic I need input here.

(Thanks @TheJuanAndOnly99 for highlighting this)

L25-26 doesn't match the revised team/role strategy. Previously, we discussed having FINOS POC as the only person in the top-level group, but now the top-level group holds all CCC project members.

For these entries, we want to have only the FINOS point of contact as the owner.

Option 1: We just switch tack on this line, and enter the FINOS POC (Rob) by name. Option 2: We create a FINOS POC role that contains Rob and, in the event of a transition, whomever he hands off the POC role to.

WDYT?

Option 2 feels better to me.

eddie-knight commented 3 weeks ago

@robmoffat @TheJuanAndOnly99 do yall agree? Can you make this happen and then I'll add the matching change to the PR?

TheJuanAndOnly99 commented 3 weeks ago

I'll defer to @robmoffat here.

robmoffat commented 3 weeks ago

This is basically setting who gets to review PRs, right? I don't think it should be me or anyone from FINOS. I think what you have (get everyone in the ccc project team to review it) is probably the right answer.

eddie-knight commented 3 weeks ago

This is basically setting who gets to review PRs, right?

Yep, a PR can be merged with an approval from any member of the listed group.

Since we want the highest level of review on formation docs and the top level md files, I put a required review from the SteerCo.