Add additional approvers to each WG

eddie-knight commented 2 months ago

Feature Request

Description of Problem:

The current list of approvers for each WG includes only the leads of each working group. Because a contributor cannot approve their own pull request, a PR created by a WG Lead cannot be merged if it modifies a resource their WG owns.

Potential Solutions:

In accordance with the member roles guidelines, add inaugural approvers to the GitHub Team corresponding to each working group.

Note that the guideline is not established as a firm policy, and WG leads can make personal judgment calls regarding the qualifications of their WG's approvers.

Also note that SteerCo members are not disqualified from being approvers, but we should try to minimize the number of WGs that any one person is an approver in.

### TODO
- [ ] Communications WG
- [x] Community Structure WG
- [ ] Duplication Reduction WG
- [ ] Taxonomy WG
- [ ] Security WG
- [ ] Delivery WG

eddie-knight commented 2 months ago

The requirement for another approver in @finos/ccc-wg-delivery is currently a blocker for #223.

eddie-knight commented 2 months ago

Also, the requirement for another approver in @finos/ccc-wg-security is a blocker for https://github.com/finos/common-cloud-controls/pull/153.

damienjburks commented 1 month ago

@eddie-knight I'd like to be an approver for the @finos/ccc-wg-security. Is that allowed?

eddie-knight commented 1 month ago

I'm of the opinion that it's a stopgap, but it's up to Michael to determine how approvers are selected for that WG.

If we are having a hard time finding additional approvers, it might be good to discuss contributor recruitment with the Comms WG.

It may also be good to bring this up with the SteerCo via email or on our next call.

github-actions[bot] commented 3 weeks ago

This issue will be closed as stale in 7 days. Please update this issue if it is still needed.

finos / common-cloud-controls