search

finos / common-domain-model

The CDM is a model for financial products, trades in those products, and the lifecycle events of those trades. It is an open source standard that aligns data, systems and processes and is available as code in multiple languages for easy implementation across technologies.
Other
123 stars 53 forks source link

ValuationDate type and attributes not properly defined #2081

Open tomhealey-icma opened 1 year ago

tomhealey-icma commented 1 year ago

type ValuationDate has multiple issues: 1) Attribute singleValuationDate and multipleValuationDates are not a date at all and do not have any date attributes. They actually hold actually an int attribute to define a number of business days. 2) fxFixingDate and fxFixingSchedule should not be defined as fx only. 3) Since ValuationDate is not a date but a set of attributes to define or adjust a value date it should be called something like ValuationDateSpecification

eteridvalishvili commented 8 months ago

Hi @tomhealey-icma Can we link this issue to the Contribution Review Working Group Board if this hasn't been resolved yet? Please confirm if it's okay to close.

eteridvalishvili commented 6 months ago

Hi @tomhealey-icma Following up to see if this issue can be closed.