eteridvalishvili commented 8 months ago

CDM Contribution Review Working Group Minutes

Meeting Host: David Shone, ISDA

Date

February 6th, 2024 - 10 am ET / 3 pm GMT

Untracked attendees

Fullname, Affiliation, (optional) GitHub username

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.
All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.
FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact legal@finos.org with any questions.
FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[x] Convene & roll call (5mins)
[x] Display FINOS Antitrust Policy summary slide
[x] Review Meeting Notices (see above)
[ ] Approve past meeting minutes
- [x] https://github.com/finos/common-domain-model/issues/2613
[ ] Release of CDM 5.5 (target: Fri 9-Feb) - See current release note
- [ ] Dependency update (required to unblock DRR): https://github.com/finos/common-domain-model/pull/2672
- [ ] Overlap between the representation of the Package Transaction Price and Spread: https://github.com/finos/common-domain-model/issues/2676 RGuitart- TradeHeader
[ ] DocReference discussion on best practice- CRayner, ISLA
[ ] AOB, Q&A & Adjourn (5mins)

Minutes

Release of CDM 5.5 (target: Fri 9-Feb) - See current release note • Dependency update (required to unblock DRR): [5.x.x] Update bundle dependency for translate fix for FpML oilPhysicalLeg #2672 Leo Labeis- REGnosys • Overlap between the representation of the Package Transaction Price and Spread: Overlap between the representation of the Package Transaction Price and Spread #2676 RGuitart- TradeHeader • Both approved for release by group • Question on 2676- is it a breaking change- answer no, since it is adding attributes rather than changing attributes DocReference discussion on best practice- CRayner, ISLA • CR raised that a lot of text is now in the model under docReference making it a little unwieldy and proposed that there should be a move towards referencing external sources where possible • Lyteck L, ISDA- proposed that a clearer set of principles should be defined to determine when something should be used in docReference • CR took an action to form a sub-group to discuss those principles • Leo L noted that now docreference is being used as regulatory references for DRR, driving some of the Rosetta functionality, though provided the external references were accessible these concepts do not need to be mutually exclusive AOB • Adam Turski raised this question Create_TradeState does not set required field activityDate on ClosedState when closing position · Issue #2145 · finos/common-domain-model (github.com) • Discussion outcome was that it was agreed it would be a good idea to fix this bug • Adam to raise a PR to fix