finos / common-domain-model

The CDM is a model for financial products, trades in those products, and the lifecycle events of those trades. It is an open source standard that aligns data, systems and processes and is available as code in multiple languages for easy implementation across technologies.
Other
113 stars 50 forks source link

Proposal 1: Draft PRs and Ready for Review #2973

Open tomhealey-icma opened 3 weeks ago

tomhealey-icma commented 3 weeks ago

Discussed in https://github.com/finos/common-domain-model/discussions/2789

Originally posted by **tomhealey-icma** March 19, 2024 Current: Most PRs are submitted as “review ready” even if they are not labeled. Proposal: All PRs will be submitted as Draft. A contributor/editor can move from Draft after all labels are properly set. This process will be implemented using Github actions. Feedback: BL:This seems ok to me. We’ll need to define who can change the labels, and what labels should be used to trigger reviews and then implementation. CR: What is the definition of a Draft PR please? We’re waiting on FINOS to give us Triage permissions on the Editor role which will allow contributors to add the labels themselves which should help here. We still need to cater for general Participants submitting PRs though so a Draft status would make sense. The more that can be done automatically the better. Result: General agreement. Draft is defined by Github. Moving to Ready state would require proper labelling. Labelling is the responsibility of the contributor but maintainers may have an opinion on the labels.