Lionel Smith-Gordon Phase-1-Asset-Refactor

[netlify[bot]]

❌ Deploy Preview for finos-cdm failed. Why did it fail? →

Name	Link
🔨 Latest commit	605a001715eaa58a43e76415cb7cc11990476715
🔍 Latest deploy log	https://app.netlify.com/sites/finos-cdm/deploys/667ee1167f109d0008e2c7e4

[JBZ-Fragmos]

@Oblongs

not sure the suggestion below (recorded in some Minutes) have been taken into account ? please let me know about it

This Enum type should be included in the scope of our discussion

I guess “Asset” concept will imply refactoring here, for instance :

• shall we replace Share by Asset ?
• else shall we list all Asset types inside as new values that would extend the existing in the Enum list in order to encompass explicitly here all types of Asset ?

[JBZ-Fragmos]

in addition to the above @Oblongs,

change proposal :

• simplifying_ PriceQuantity by removing attributes :
  • SettlementTerms
  • and BuyerSeller

• considering renaming as well ?
  • new name ObservablePriceQuantity (instead of current name PriceQuantity)

rationale :

• cause of potential overlaps/inconsistencies, because these attributes are redundant with regards to similar ones in payoutBase and/or *settlementCommitment** recently discussed :

• rationale for renaming is just to evidence the fact such type would effectively contain exactly these 3 items : observable+price+quantity...

[JBZ-Fragmos]

another improvement to discuss please @Oblongs about some PriceSchedule and QuantitySchedule in Payout for which [metadata address] is currently missing

Background

Purpose of having [metadata address] for PriceSchedule and QuantitySchedule in Payout, permits to reference the corresponding type with [metada location] in TradeLot.

One main benefit for having such referencing is for updating the related components inside Payout in regards of a LifeCycle Event represented with quantityChange Instruction (or more generally with any Intruction that may be contemplated where PriceSchedule or QuantitySchedule would be used).

In case such reference annotation is missing for a given PriceSchedule or QuantitySchedule component in Payout, there is no other ways to update it than using termsChange Instruction (that being heavy compared to quantityChange for the only purpose of updating a kind of components for which quantityChange is originally designed)

Problem Statement

The [metadata address] annotation is missing for PriceSchedule and QuantitySchedule in some Payout, that is to say the possibility to reference PriceSchedule and QuantitySchedule with [metada location] fromTradeLot is not implemented in consistent/exhaustive** manner in current model e.g. in some case it is present (OK) but in ther cases it is missing (KO=inconsistent)

Example where it is already present (OK = already aligned with target)

• payoutBase->priceQuantity->priceSchedule
• payoutBase->priceQuantity->quantitySchedule
• performancePayout -> (initialValuationPrice, interimValuationPrice, finalValuationPrice)
• etc.

Example where it is missing (KO = need to insert the [metadata address] for these items)

• optionPayout->exerciseTerms->strike

• performancePayout->returnTerms->varianceReturnTerms->varianceStrikePrice

• performancePayout->returnTerms->volatilityReturnTerms->volatilityStrikePrice

• performancePayout->returnTerms->volatilityReturnTerms->vegaNotionalAmount

• performancePayout->returnTerms->correlationReturnTerms->correlationStrikePrice

• etc. (other ocurrences may exist)

• also missing for mostly all ocurrences where a kind of barrier is represented (usually that is because poor type "number" being used with no good reason, instead of using more rich type such as "PriceSchedule") :

  • performancePayout->returnTerms->varianceReturnTerms->varianceCapFloor->unadjustedVarianceCap
  • trigger->level
  • etc. (other ocurrences may exist)

[Oblongs]

change proposal :

• simplifying_ PriceQuantity by removing attributes :
  • SettlementTerms
  • and BuyerSeller

This aligns with the scope of the planned 3rd tranche of changes and is not relevant to this PR.

[Oblongs]

another improvement to discuss please @Oblongs about some PriceSchedule and QuantitySchedule in Payout for which [metadata address] is currently missing

This proposal is also aligned with the third tranche and is not relevant to this PR.