search

finos / common-domain-model

The CDM is a model for financial products, trades in those products, and the lifecycle events of those trades. It is an open source standard that aligns data, systems and processes and is available as code in multiple languages for easy implementation across technologies.
Other
142 stars 60 forks source link

Added the Joule unit "J" in CapacityUnitEnum #3196

Open LuciaCortesTH opened 1 month ago

LuciaCortesTH commented 1 month ago

Background

In has been seen that in the ExternalUnitOfMeasure1Code from the 2Q2024 ISO External CodeSets v1, the unity Joule is supported in the Enum. However, in CDM this is not the case, as it does not appear anywhere in the CapacityUnitEnum.

Captura de pantalla 2024-10-22 111440

Proposal

We believe that for completeness and to align with the 2Q2024 ISO External CodeSets v1, it should be included in the CapacityUnitEnum like this:

Captura de pantalla 2024-10-24 111911

This proposal was approved in the APAC/JFSA DRR Peer Review.

Compatibility

Since this contribution would just include a new function in CDM, there are no issues with compatibility.

In DRR, as this value is required in version 5, we need to apply the changes in CDM 5. Aditionally we will contribute it to CDM version 6 to keep it updated with version 5.

LuciaCortesTH commented 1 month ago

PR 1: https://github.com/finos/common-domain-model/pull/3198 PR 2: https://github.com/finos/common-domain-model/pull/3197 Release Notes: RN_CapacityUnitEnum.md Story 3551 in Air Table