Closed nkolba closed 2 years ago
Thanks for the submission @nkolba (tagging @finos/fdc3-maintainers, @finos/fdc3-editors @finos/fdc3-participants for visibility) and the related note to the FINOS Community List.
I suggest we keep the contribution open at least for another week to encourage further feedback - we will also be reviewing this contribution at the upcoming 4/20 Governing Board meeting, so expect more socialization.
Thanks!
I gave this a try and really liked it. I will fully admit that when I first launched into really trying to understand FDC3 I was a bit lost from reading documentation alone as it required a more hands on tutorial. The prior chrome example you provided was invaluable to me getting a concrete understanding of how to not only use FDC3 workflows effectively but also was foundational to implementing support for our own proprietary container. It was a bit constrained in its practicality due to being an extension. This offers a full working example on top of an open source container which will further extend the reach and applicability of FDC3. I would love to see a default tab for the workbench added.
@nkolba very recent cve for prototype pollution in async came out which has results in two high vulnerabilities due to transitive dependencies in what is currently being reviewed. Luckily an audit fix does resolve it.
Thanks @bingenito !
I've just merged a PR to address the vulnerabilities.
and default tab for workbench should be simple. let's get it on the roadmap!
Thanks for creating this @nkolba being new to FDC3 this was a great way to get up and running with a reference implementation within an Electron container.
Look forward to seeing how this project evolves.
Great to see a reference implementation @nkolba, this is a perfect accelerator for the FDC3 standard’s adoption.
Olivier.
On Apr 22, 2022, at 8:31 AM, Vinay Mistry @.***> wrote:
Thanks for creating this @nkolba being new to FDC3 this was a great way to get up and running with a reference implementation within an Electron container.
Look forward to seeing how this project evolves.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are on a team that was mentioned.
Looks like a great start @nkolba! I'm also looking forward to seeing it evolve and hopefully to increase uptake of the standard.
I've dropped you a PR with an FDC3 Workbench appD record:
A few things I noticed along the way to add to the todo list:
icon
field in addition to icons
,icons[].icon
rather than icons[].src
start_url
field (a URL field was missing in 1.0-1.2, but will be corrected in 2.0 - I think the standard approach was to embed the URL in the manifest field)setTopBrowserview
) as they default to transparent, otherwise add and remove the browserviews to avoid this.very useful - definitely a must a have in our community
I think this together with the workbench contributed by Cosaic last year are most of the way there in terms of being able to reliably test FDC3 applications - it'll be a great result if we can build the tooling to fully automate testing both in isolation and at the integration level between apps.
Given the overwhelming support for this issue by @finos/fdc3-maintainers like @kriswest and @rikoe, financial institutions like @bingenito and @kprado1969, buy-side firms like @jonfreedman and vendors like @opoupeney and @mistryvinay, we will approve this contribution for incubation in FINOS. Congrat @nkolba!
@maoo @TheJuanAndOnly99 please proceed with onboarding, and @Julia-Ritter can provide logo once it's been approved.
Please note that only FINOS members can propose new projects. If you're interested in membership, see https://www.finos.org/membership-benefits#become-a-member.
Business Problem
Currently, although FDC3 is an open source standard, there are no fully open source implementations that include all elements of the standard and provides a viable core for FDC3 developers.
Proposed Solution
A community maintained project that provides an open source core for FDC3 development. This includes both an FDC3 Desktop Agent implemented in Electron, and an App Directory implementation.
Tentative Roadmap
Short/medium term goals are:
Current State
The project supports FDC3 1.2 with full API coverage. It has recently been made public and currently has 2 contributors.
Existing Materials
https://github.com/nkolba/electron-fdc3
Development Team
Maintainers
Committed maintainer is Nicholas Kolba, nick@kolbito.com, nkolba
Confirmed contributors
Target Contributors
FDC3 developers, financial app developers, general electron/web developers.
Infrastructure needs
Mailing list
What's next?
Upon submission of this project proposal, the FINOS team will get in touch with you to discuss next steps.
Contribution process (v. 1.1, last updated on December 20, 2021)
Below is the list of tasks that FINOS Team and the contribution author go through in order to complete the FINOS contribution process. Please do not edit these contents at contribution time!
Kick-off meeting
FINOS Contrib POC
Rob Moffat
Proposal (Lead Maintainer)
[x] Lead maintainer to send out announcement to community@finos.org using this template:
Identify project meta (Lead: FINOS Contrib POC, Support: FINOS Marketing)
Electron FDC3 Desktop Agent & App Directory
electron-fdc3
platform and runtimes / containers
GitHub Actions
Only README available
Maintainers, contributors and CLAs (Lead: FINOS Contrib POC, Support: FINOS infra)
Project Communication Channel(s)
reusing fdc3@finos.org
Code validation (only if code is contributed) (Lead: FINOS Infra)
Approval (Lead: FINOS Infra)
Code transfer (Lead: FINOS Infra)
Admin
to all repositories to transferCONTRIBUTING.md
LICENSE
(look for{}
placeholders)<project-name>-maintainers
GitHub team and invite usersfinos-admins
(Maintain
role) andfinos-staff
(Triage
role) team permissionsInfra setup (Lead: FINOS Infra)
staging
branch onfinos/finos-landscape
finos/metadata
changes on master (will udpdatelandscape.yml
infinos/finos-landscape
)staging
branch onfinos/finos-landscape
finos
- use@finos
scope in package.json - see https://github.com/finos/electron-fdc3/blob/main/package.json#L2Announcement (Lead: FINOS Contrib POC)