Improve validation messages identified

finos / datahelix

The DataHelix generator allows you to quickly create data, based on a JSON profile that defines fields and the relationships between them, for the purpose of testing and validation

https://finos.github.io/datahelix/

Apache License 2.0

141 stars 50 forks source link

Improve validation messages identified #1688

Closed matthewdunsdon closed 4 years ago

matthewdunsdon commented 4 years ago

Description

Address some of the issues identified regarding validation messages.

Changes

To ensure these changes are not breaking, a lot of validation tests are added before any fixes.
Add quotes in validation messages
Add validation check for field type
Add validation check for field being null
Update granularity and offset validation checks
Update value data type validation checks
Update validation checks for if's else and inMap's values

Issue

Resolves #1675

matthewdunsdon commented 4 years ago

Looks good from a quick review. The coding style does state that opening braces should be on the same line as the condition (if), which you have changed in the cucumber helper. I presume this wasn't intentional?

Good to know, will fix now.

Would be good to document the styling as it was not clear what the rules are. Maybe committing .idea/codeStyles would be helpful.

ghost commented 4 years ago

Looks good from a quick review. The coding style does state that opening braces should be on the same line as the condition (if), which you have changed in the cucumber helper. I presume this wasn't intentional?

Good to know, will fix now.

Would be good to document the styling as it was not clear what the rules are. Maybe committing .idea/codeStyles would be helpful.

Sounds like a good idea, could you raise an issue for this addition?

For completeness, the coding styles were referenced here, but have since been removed. https://github.com/finos/datahelix/commit/6456242fc2e0e0631f01f24a51965dfffb23a665#diff-8cc7b2b0d78dd2501610391c086a8516

matthewdunsdon commented 4 years ago

opening braces should be on the same line as the condition (if), which you have changed in the cucumber helper. I presume this wasn't intentional

Is this also true for all cases (i.e. methods, classes, lambdas)?