search

finos / datahub

DataHub - Synthetic data library
https://datahub.finos.org
Apache License 2.0
80 stars 13 forks source link

Issues/issue 5 addtional samplers #34

Closed grovesy closed 4 years ago

grovesy commented 4 years ago

Sure will add

Sent with B

grovesy commented 4 years ago

node_modules removed

zheyu-wang-tony commented 4 years ago

@maoo Hi Mao, would you please help to check why PR need a pylint status check? I cannot disable it in the setting page since I don’t have enough entitlement.

zheyu-wang-tony commented 4 years ago

@grovesy Hi Paul, I think it’s not related to build action, we need to disable it in branch setting which is not visible to us right now.

grovesy commented 4 years ago

@grovesy Hi Paul, I think it’s not related to build action, we need to disable it in branch setting which is not visible to us right now.

Yes noticed - thought I would just double check

zheyu-wang-tony commented 4 years ago

@maoo Hi Mao, would you please help to check why PR need a pylint status check? I cannot disable it in the setting page since I don’t have enough entitlement.

@finos-admin

finos-admin commented 4 years ago

@zheyu-wang-tony - I've disabled pylint from the checks, I think it was an old check that was introduced by Probot Settings (now disabled).

The PR can be merged now. Sorry for the inconvenience

grovesy commented 4 years ago

wohoo .. cheers Mao