search

finos / datahub

DataHub - Synthetic data library
https://datahub.finos.org
Apache License 2.0
80 stars 13 forks source link

Remove Erroring "Create Comment" from Docusaurus website build #43

Closed mcleo-d closed 3 years ago

mcleo-d commented 3 years ago

Description

This pull request removes Create comment from docusaurus.yml which is breaking pull request #39. The PR also brings commit e9c0870 into its own context as the Create comment error means #39 will never be merged to apply e9c0870.

Removed Code

    - name: Create comment
      if: github.event_name == 'pull_request'
      uses: peter-evans/create-or-update-comment@v1
      with:
        token: ${{ secrets.GITHUB_TOKEN }}
        issue-number: ${{ github.event.number }}
        body: Website [preview is available](https://${{ github.actor }}.github.io/${{ env.REPO_NAME }})
mcleo-d commented 3 years ago

@grovesy and @maoo,

To merge this pull request datahub-build might need to be temporarily disabled as the error this PR fixes is blocking the auto merge of the PR.

Thanks for your support.

James.

mcleo-d commented 3 years ago

@grovesy and @maoo

I have just reviewed the checks and can seen the build passed ... https://github.com/finos/datahub/pull/43/checks

This means only the review might be needed @grovesy 👍

James.