Closed bingenito closed 3 weeks ago
Work will start now that 2.0 has been transferred and republished
Experimental Order, OrderList, Product, Trade & TradeList context types will be intentionally left out until official (unless requested)
Intents are still not defined/listed within fdc3-dotnet so any additions to enums/constants are not replicated
Intents are still not defined/listed within fdc3-dotnet so any additions to enums/constants are not replicated
@bingenito This is all we have in TS for intents: https://github.com/finos/FDC3/blob/fdc3-for-web/src/intents/Intents.ts Theres this JSON file as well (which contains displayNames that should go as they are deprecated). Perhaps you could script something based on the file?
I note the following are missing from the JSON file: SendChatMessage, ViewAnalysis, ViewChat, ViewMessages - I'll drop a quick PR to fix those ommissions
Experimental Order, OrderList, Product, Trade & TradeList context types will be intentionally left out until official (unless requested)
Boo, here I was hoping you'd be helping to drive getting them right 😜
Intents are still not defined/listed within fdc3-dotnet so any additions to enums/constants are not replicated
@bingenito This is all we have in TS for intents: https://github.com/finos/FDC3/blob/fdc3-for-web/src/intents/Intents.ts Theres this JSON file as well (which contains displayNames that should go as they are deprecated). Perhaps you could script something based on the file?
I note the following are missing from the JSON file: SendChatMessage, ViewAnalysis, ViewChat, ViewMessages - I'll drop a quick PR to fix those ommissions
@kriswest As this was never there for unpublished 1.2 or 2.0, I'll leave out of this PR but will create a separate issue to add an Intents.cs with public static strings.
Added a PR to fix and simplify the JSON file: https://github.com/finos/FDC3/pull/1304
Checklist extracted from FDC3 CHANGELOG
Added
[ ] Added CreateInteraction intent. To be used when a user wants to record an interaction into a system. New context Interaction also introduced. An interaction might be a call, IM, email, a meeting (physical or virtual) or the preparation of some specialist data. (https://github.com/finos/FDC3/pull/747)[ ] Added error examples to the /v2 App Directory API routes (https://github.com/finos/FDC3/pull/973)[ ] Added a SendChatMessage intent to be used when a user wants to send a message to an existing chat room. (https://github.com/finos/FDC3/pull/794)[ ] Added a ViewChat Intent to be used when a user wants to open an existing chat room. (https://github.com/finos/FDC3/pull/796)[ ] Added a ViewMessages intent to be used when a user wants to search and see a list of messages. (https://github.com/finos/FDC3/pull/797)[ ] Added an indication that applications, that can be launched to receive intents or context via a raised intent or open with context, SHOULD add their context or intent listeners via the API within 15 seconds, and that Desktop Agents MUST allow at least a 15 second timeout for them to do so, and MAY set a longer timeout (https://github.com/finos/FDC3/pull/987)Added @experimental Order, OrderList, Product, Trade & TradeList context types.(https://github.com/finos/FDC3/pull/1021)[ ] Added Agent Bridging as an @experimental 5th part of the FDC3 Standard. (https://github.com/finos/FDC3/pull/968)[ ] Added a description of the standards use of JSON Schema to define context types and Bridging messages. (https://github.com/finos/FDC3/pull/1020)[ ] Documentation for standardized Context types was added to their JSON Schema files and TypeScript interfaces generated from them, so that they may act as a 'single source of truth' for Context definitions. (https://github.com/finos/FDC3/pull/1020)Changed
[ ] Updated the StartChat intent to return a reference to the room. (https://github.com/finos/FDC3/pull/794)[ ] Corrected API functions and object types to always use string instead of String (https://github.com/finos/FDC3/pull/924)[ ] The App Directory OpenAPI schema was converted from YAML to JSON Schema, containing the same definitions. (https://github.com/finos/FDC3/pull/1035)[ ] Switched to union types (from enums) for constrained string values in generated source files as they provide better type checking and cross-compatability of types. (https://github.com/finos/FDC3/pull/1093)Deprecated
Fixed
[ ] Further clarified the difference between the behavior of User channels and other channel types on joinUserChannel/addContextListener. (https://github.com/finos/FDC3/pull/971)[ ] Clarified description of the behavior of IntentResolution.getResult() when the intent handler returned void (which is not an error). (https://github.com/finos/FDC3/pull/1004)[ ] An error was fixed in the appD schema where launch details sub-schemas were combined with oneOf, rather than anyOf. This causes validation errors for web or online native apps as their details elements overlap on a url field. (https://github.com/finos/FDC3/pull/1034)[ ] The appD icon and screenshot sub-schemas were updated to require the src value is set and restrict additional values, ensuring that common mistakes (such as ussing a url rather than src field are caught by the schemas when used to validate. (https://github.com/finos/FDC3/pull/1037)[ ] Linting, spell checking other corrections were applied to markdown syntax throughout the FDC3 documentation (https://github.com/finos/FDC3/pull/1032)[ ] Corrected bad example URLs in the App Directory overview/discovery page in the current and past versions as they did not agree with the paths provided in the API specification and OpenAPI schema. (https://github.com/finos/FDC3/pull/1060)