finos / fdc3-dotnet

.NET Standard FDC3 declarations to implement concrete FDC3 compatible .NET desktop agents
Apache License 2.0
10 stars 13 forks source link

Update to FDC3 2.1 #74

Closed bingenito closed 3 weeks ago

bingenito commented 1 year ago

Checklist extracted from FDC3 CHANGELOG

Added

Changed

Deprecated

Fixed

bingenito commented 9 months ago

Work will start now that 2.0 has been transferred and republished

bingenito commented 4 months ago

Experimental Order, OrderList, Product, Trade & TradeList context types will be intentionally left out until official (unless requested)

bingenito commented 4 months ago

Intents are still not defined/listed within fdc3-dotnet so any additions to enums/constants are not replicated

kriswest commented 3 months ago

Intents are still not defined/listed within fdc3-dotnet so any additions to enums/constants are not replicated

@bingenito This is all we have in TS for intents: https://github.com/finos/FDC3/blob/fdc3-for-web/src/intents/Intents.ts Theres this JSON file as well (which contains displayNames that should go as they are deprecated). Perhaps you could script something based on the file?

I note the following are missing from the JSON file: SendChatMessage, ViewAnalysis, ViewChat, ViewMessages - I'll drop a quick PR to fix those ommissions

kriswest commented 3 months ago

Experimental Order, OrderList, Product, Trade & TradeList context types will be intentionally left out until official (unless requested)

Boo, here I was hoping you'd be helping to drive getting them right 😜

bingenito commented 3 months ago

Intents are still not defined/listed within fdc3-dotnet so any additions to enums/constants are not replicated

@bingenito This is all we have in TS for intents: https://github.com/finos/FDC3/blob/fdc3-for-web/src/intents/Intents.ts Theres this JSON file as well (which contains displayNames that should go as they are deprecated). Perhaps you could script something based on the file?

I note the following are missing from the JSON file: SendChatMessage, ViewAnalysis, ViewChat, ViewMessages - I'll drop a quick PR to fix those ommissions

@kriswest As this was never there for unpublished 1.2 or 2.0, I'll leave out of this PR but will create a separate issue to add an Intents.cs with public static strings.

kriswest commented 3 months ago

Added a PR to fix and simplify the JSON file: https://github.com/finos/FDC3/pull/1304