Closed maoo closed 3 years ago
Here's the preview - https://mystifying-swartz-9aa401.netlify.app/ , which is generated from the new-website
branch (see https://github.com/finos/finos-fo/pull/70).
There's an issue with the image size and probably other CSS fixes. @grizzwolf , could you please have a look? /CC @agitana
hi @maoo looks good to me, thank you
-I agree the image sizes should be fixed on the home page.
-It also seems like there should be menu items that link to the work on product control common template and commodities payout and not just the financial objects.
-Same thing with the left menu once you click on Into.
@maoo I cloned the repo, but when I start the website, it is the current version at https://fo.finos.org/ - I'm not sure how to get to the version you're working on currently.
If I run the inspector on the https://mystifying-swartz-9aa401.netlify.app/ page - I see two issues with that one section you're having issues with:
-div class "Block Image" - the flex and max-width sizes are 500px. If you drop both (especially the flex) to 150px, that would correct the desktop version of the site. (however those icons seem to drop off when in the mobile version?).
Code should look like the below - but I'm not sure where to fix that in your version - probably in the custom CSS file? Also - that "Flex" could also be 0 1 150px:
.imageAlignSide .blockImage { flex: > 0 0 150px; max-width: 150px; }
@grizzwolf - uh, my bad! Forgot a tiny yet important detail: i'm working on the new-website
branch ! 😄
I've added your fix, and it actually works, see https://mystifying-swartz-9aa401.netlify.app/ .
The SVG is still cut, but it's the same image used by the landscape, so it should be fine. Any idea what's wrong? Worse case, we can export to PNG and use those. WDYT?
As discussed with @toshaellison - I removed images for now.
@agitana - the preview is ready to be shared with the FO team: we removed content coming from the previous FO initiative, but more cleanup on the repo must happen. I can work on a PR, but given the board meeting is close, I'd ask if we can merge these website changes today/tomorrow and go live on fo.finos.org.
TY!
PR merged - fo.finos.org updated.
Update fo.finos.org according to the new team composition and initiatives.
Content must be taken from README.md