making COOKIE_SECRET an env var

finos / git-proxy

Deploy custom push protections and policies on top of Git

https://git-proxy.finos.org

Apache License 2.0

123 stars 117 forks source link

making COOKIE_SECRET an env var #690

Open kulp006 opened 3 months ago

kulp006 commented 3 months ago

make COOKIE_SECRET an env var instead of checking in proxy.config.json

https://github.com/finos/git-proxy/blob/fd638483c70bc84f3f9cedb6e10f8d0a18bafacf/proxy.config.json#L3

JamieSlome commented 3 months ago

Thanks for creating the issue @kulp006. Can you explain what your requirement is or why you think this should be the case?

coderhs commented 1 month ago

I am guessing the recommendation to use ENV variable is to make sure that new installations changes it. I can work on it if the request is still valid.

Aditya-PS-05 commented 3 weeks ago

Can you assign me this task?

JamieSlome commented 3 weeks ago

@Aditya-PS-05 - sure!

Aditya-PS-05 commented 3 weeks ago

@JamieSlome , Please review my pr.