search

finos / jupyterlab_templates

Support for jupyter notebook templates in jupyterlab
Apache License 2.0
396 stars 68 forks source link

Increased timeout for requests #242

Closed cccs-nik closed 7 months ago

cccs-nik commented 7 months ago

Is your feature request related to a problem? Please describe. Some of our templates live on a remote server that is sometimes pretty slow which means the extension will not load properly (missing button and menu option) with the default 5 second timeout for the requests.

Describe the solution you'd like An arbitrary value for timeout that is higher than 5 seconds (something like 15 seconds) or a configurable timeout.

Describe alternatives you've considered N/A

Additional context Example on my fork with increased timeout to 60 seconds which fixed my issue: https://github.com/cccs-nik/jupyterlab_templates/compare/main...cccs-nik:jupyterlab_templates:feature/increased-timeout?expand=1 It's missing the increased timeout on the second request which would also sometimes fail but wasn't as problematic (you could try initializing a notebook again easily). I also moved ILauncher from 'optional' to 'requires'. I'm not sure why ILauncher would be optional but I don't think it really was an issue for me.

timkpaine commented 7 months ago

this should be resolved in the next release, im using fetch so its browser dependent but for example in chrome it will be 300 seconds.