search

finos / legend-pure

Legend Pure module
https://legend.finos.org
Apache License 2.0
66 stars 136 forks source link

Remove static JSON method in PureModelVersion #738

Closed aziemchawdhary-gs closed 12 months ago

aziemchawdhary-gs commented 1 year ago

Deleting legacy code - we should use the non-JSON method and let client handle formatting if need. Current usages take the JSON and parse to get the model version number - so we may as well just use the non-JSON method and get version number directly

github-actions[bot] commented 1 year ago

Test Results

   522 files  ±0     522 suites  ±0   29m 58s :stopwatch: + 1m 32s 3 828 tests ±0  3 796 :heavy_check_mark: ±0  32 :zzz: ±0  0 :x: ±0  5 131 runs  ±0  5 099 :heavy_check_mark: ±0  32 :zzz: ±0  0 :x: ±0 

Results for commit ab2bf8c0. ± Comparison against base commit ea0f5bfd.

aziemchawdhary-gs commented 1 year ago

/easycla

aziemchawdhary-gs commented 12 months ago

/easycla