finos / legend-pure

Legend Pure module
https://legend.finos.org
Apache License 2.0
66 stars 136 forks source link

Fix URLPatternLibrary regex exception handling #764

Closed kevin-m-knight-gs closed 8 months ago

kevin-m-knight-gs commented 8 months ago

Fix URLPatternLibrary regex exception handling, specifically the generation of the source information. Previously the end coordinates were not supplied. Also, the previous behavior yielded different results depending on the Java version in use. This, in particular, meant that the success of some tests depended on the Java version.

In passing, use named groups in the main regex to make the code clearer.

github-actions[bot] commented 8 months ago

Test Results

   537 files  ±0     537 suites  ±0   22m 32s :stopwatch: +54s 3 951 tests +1  3 919 :heavy_check_mark: +1  32 :zzz: ±0  0 :x: ±0  5 270 runs  +1  5 238 :heavy_check_mark: +1  32 :zzz: ±0  0 :x: ±0 

Results for commit 7cf0f93d. ± Comparison against base commit 72ac438a.