finos / legend-pure

Legend Pure module
https://legend.finos.org
Apache License 2.0
66 stars 136 forks source link

Fix a bug with the implementation of map in compiled mode #768

Closed kevin-m-knight-gs closed 8 months ago

kevin-m-knight-gs commented 8 months ago

Fix a bug with the implementation of map in compiled mode. Specifically, the implementation used when calling map via eval/evaluate didn't properly handle the case where the collection to map over had cardinality 1 or 0..1.

In passing, add better error handling in Reactivator.

github-actions[bot] commented 8 months ago

Test Results

   537 files  ±0     537 suites  ±0   25m 3s :stopwatch: + 2m 11s 3 954 tests +3  3 922 :heavy_check_mark: +3  32 :zzz: ±0  0 :x: ±0  5 276 runs  +6  5 244 :heavy_check_mark: +6  32 :zzz: ±0  0 :x: ±0 

Results for commit 9f4958fc. ± Comparison against base commit 0febc942.

:recycle: This comment has been updated with latest results.

kevin-m-knight-gs commented 8 months ago

The test is curtesy of @pierredebelen