finos / legend-pure

Legend Pure module
https://legend.finos.org
Apache License 2.0
66 stars 136 forks source link

Fix bug with dynamic evaluation of and/or #771

Closed kevin-m-knight-gs closed 7 months ago

kevin-m-knight-gs commented 8 months ago

Fix bug with dynamic evaluation of and/or to ensure that both are short-circuit operations. That is, conjuncts/disjuncts are evaluated in order and evaluation is terminated once one evaluates to false/true. This is particularly important for cases where later conjuncts/disjuncts depend on previous ones, such as instanceOf checks followed by casts.

github-actions[bot] commented 8 months ago

Test Results

   537 files  ±  0     537 suites  ±0   23m 49s :stopwatch: +5s 3 967 tests +10  3 935 :heavy_check_mark: +10  32 :zzz: ±0  0 :x: ±0  5 306 runs  +24  5 274 :heavy_check_mark: +24  32 :zzz: ±0  0 :x: ±0 

Results for commit 1257f655. ± Comparison against base commit 56b0e3d9.