finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 113 forks source link

Add back groupBy feature to DataCube after refactoring #3254

Closed gayathrir11 closed 2 months ago

gayathrir11 commented 2 months ago

Summary

How did you test this change?

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 723936af5cdd39563e06beba32b088ff81da68f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-application-repl | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 5.73248% with 444 lines in your changes missing coverage. Please review.

Project coverage is 47.98%. Comparing base (4b8c6d0) to head (723936a). Report is 13 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3254 +/- ## ========================================== - Coverage 48.04% 47.98% -0.06% ========================================== Files 1996 1997 +1 Lines 338061 338979 +918 Branches 14865 14904 +39 ========================================== + Hits 162413 162670 +257 - Misses 174856 175622 +766 + Partials 792 687 -105 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3254?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...repl/src/stores/dataCube/DataCubeMetaModelConst.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3254?src=pr&el=tree&filepath=packages%2Flegend-application-repl%2Fsrc%2Fstores%2FdataCube%2FDataCubeMetaModelConst.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXJlcGwvc3JjL3N0b3Jlcy9kYXRhQ3ViZS9EYXRhQ3ViZU1ldGFNb2RlbENvbnN0LnRz) | `100.00% <100.00%> (ø)` | | | [.../src/stores/dataCube/core/DataCubeQuerySnapshot.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3254?src=pr&el=tree&filepath=packages%2Flegend-application-repl%2Fsrc%2Fstores%2FdataCube%2Fcore%2FDataCubeQuerySnapshot.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXJlcGwvc3JjL3N0b3Jlcy9kYXRhQ3ViZS9jb3JlL0RhdGFDdWJlUXVlcnlTbmFwc2hvdC50cw==) | `97.16% <100.00%> (+0.15%)` | :arrow_up: | | [...repl/src/components/dataCube/grid/DataCubeGrid.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3254?src=pr&el=tree&filepath=packages%2Flegend-application-repl%2Fsrc%2Fcomponents%2FdataCube%2Fgrid%2FDataCubeGrid.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXJlcGwvc3JjL2NvbXBvbmVudHMvZGF0YUN1YmUvZ3JpZC9EYXRhQ3ViZUdyaWQudHN4) | `0.00% <0.00%> (ø)` | | | [...dataCube/grid/DataCubeGridQuerySnapshotAnalyzer.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3254?src=pr&el=tree&filepath=packages%2Flegend-application-repl%2Fsrc%2Fstores%2FdataCube%2Fgrid%2FDataCubeGridQuerySnapshotAnalyzer.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXJlcGwvc3JjL3N0b3Jlcy9kYXRhQ3ViZS9ncmlkL0RhdGFDdWJlR3JpZFF1ZXJ5U25hcHNob3RBbmFseXplci50cw==) | `0.00% <0.00%> (ø)` | | | [...c/stores/dataCube/grid/DataCubeGridClientEngine.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3254?src=pr&el=tree&filepath=packages%2Flegend-application-repl%2Fsrc%2Fstores%2FdataCube%2Fgrid%2FDataCubeGridClientEngine.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXJlcGwvc3JjL3N0b3Jlcy9kYXRhQ3ViZS9ncmlkL0RhdGFDdWJlR3JpZENsaWVudEVuZ2luZS50cw==) | `0.00% <0.00%> (ø)` | | | [...l/src/stores/dataCube/core/DataCubeQueryBuilder.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3254?src=pr&el=tree&filepath=packages%2Flegend-application-repl%2Fsrc%2Fstores%2FdataCube%2Fcore%2FDataCubeQueryBuilder.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXJlcGwvc3JjL3N0b3Jlcy9kYXRhQ3ViZS9jb3JlL0RhdGFDdWJlUXVlcnlCdWlsZGVyLnRz) | `0.00% <0.00%> (ø)` | | ... and [240 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3254/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)