finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 113 forks source link

fix for small issues #3255

Closed YannanGao-gs closed 2 months ago

YannanGao-gs commented 2 months ago

Summary

fix for small issues

How did you test this change?

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: e059510811407a20180c97f28746c6d833ce84d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-query-builder | Patch | | @finos/legend-art | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-application-repl | Patch | | @finos/legend-application | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-lego | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.02%. Comparing base (af85ed7) to head (e059510).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3255 +/- ## ========================================== - Coverage 48.04% 48.02% -0.03% ========================================== Files 1997 1997 Lines 338530 338534 +4 Branches 14527 10156 -4371 ========================================== - Hits 162641 162566 -75 - Misses 175504 175583 +79 Partials 385 385 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3255?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...rators/QueryBuilderAggregateOperator\_Percentile.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3255?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fstores%2Ffetch-structure%2Ftds%2Faggregation%2Foperators%2FQueryBuilderAggregateOperator_Percentile.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL3N0b3Jlcy9mZXRjaC1zdHJ1Y3R1cmUvdGRzL2FnZ3JlZ2F0aW9uL29wZXJhdG9ycy9RdWVyeUJ1aWxkZXJBZ2dyZWdhdGVPcGVyYXRvcl9QZXJjZW50aWxlLnRz) | `96.32% <100.00%> (+0.06%)` | :arrow_up: | | [...DataSpaceQueryBuilderTemplateQueryPanelContent.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3255?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fcomponents%2Fquery-builder%2FDataSpaceQueryBuilderTemplateQueryPanelContent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvY29tcG9uZW50cy9xdWVyeS1idWlsZGVyL0RhdGFTcGFjZVF1ZXJ5QnVpbGRlclRlbXBsYXRlUXVlcnlQYW5lbENvbnRlbnQudHN4) | `0.00% <0.00%> (ø)` | | | [...omponents/fetch-structure/QueryBuilderTDSPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3255?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Ffetch-structure%2FQueryBuilderTDSPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvZmV0Y2gtc3RydWN0dXJlL1F1ZXJ5QnVpbGRlclREU1BhbmVsLnRzeA==) | `74.41% <0.00%> (ø)` | | ... and [52 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3255/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)