finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 113 forks source link

Allow DND projection column to post-filter condition value #3264

Closed travisstebbins closed 2 months ago

travisstebbins commented 2 months ago

Summary

Allow users to DND a projection column to the right-side value of a post-filter condition. This allows users to create a post-filter condition where they can compare one projection column value to another projection column value.

How did you test this change?

DND columns to post-filter condition values: DNDColumns

Replace post-filter condition value with new column: ReplaceColumnValues

DND constants to post-filter condition values (existing behavior, verifying it still works): Constants

DND column to the condition property (left side) to create new logical grouping: CreateLogicalGroup

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 1d35c5fe12044f73dff7269341afbb347bf68491

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-query-builder | Patch | | @finos/legend-art | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-application-repl | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-application | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-lego | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 84.73684% with 29 lines in your changes missing coverage. Please review.

Project coverage is 48.06%. Comparing base (5f1b628) to head (1d35c5f). Report is 9 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3264 +/- ## ========================================== - Coverage 48.19% 48.06% -0.14% ========================================== Files 1997 1998 +1 Lines 339155 339936 +781 Branches 14982 15035 +53 ========================================== - Hits 163449 163379 -70 - Misses 174908 175701 +793 - Partials 798 856 +58 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3264?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...components/QueryBuilderConstantExpressionPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3264?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2FQueryBuilderConstantExpressionPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvUXVlcnlCdWlsZGVyQ29uc3RhbnRFeHByZXNzaW9uUGFuZWwudHN4) | `97.90% <100.00%> (+0.03%)` | :arrow_up: | | [...src/stores/QueryBuilderValueSpecificationHelper.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3264?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fstores%2FQueryBuilderValueSpecificationHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL3N0b3Jlcy9RdWVyeUJ1aWxkZXJWYWx1ZVNwZWNpZmljYXRpb25IZWxwZXIudHM=) | `84.73% <100.00%> (-0.13%)` | :arrow_down: | | [...rc/stores/shared/ValueSpecificationEditorHelper.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3264?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fstores%2Fshared%2FValueSpecificationEditorHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL3N0b3Jlcy9zaGFyZWQvVmFsdWVTcGVjaWZpY2F0aW9uRWRpdG9ySGVscGVyLnRz) | `64.98% <100.00%> (+1.77%)` | :arrow_up: | | [...ts/fetch-structure/QueryBuilderPostFilterPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3264?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Ffetch-structure%2FQueryBuilderPostFilterPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvZmV0Y2gtc3RydWN0dXJlL1F1ZXJ5QnVpbGRlclBvc3RGaWx0ZXJQYW5lbC50c3g=) | `83.17% <95.10%> (+0.67%)` | :arrow_up: | | [packages/legend-art/src/panel/PanelDropZone.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3264?src=pr&el=tree&filepath=packages%2Flegend-art%2Fsrc%2Fpanel%2FPanelDropZone.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFydC9zcmMvcGFuZWwvUGFuZWxEcm9wWm9uZS50c3g=) | `0.00% <0.00%> (ø)` | | ... and [109 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3264/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)