finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 113 forks source link

clean code for(#3257) #3266

Closed YannanGao-gs closed 2 months ago

YannanGao-gs commented 2 months ago

Summary

clean code for(#3257)

How did you test this change?

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 89082d36e82ac7fbd3ffaddca78d8de627870030

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-application-query | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 12.50000% with 28 lines in your changes missing coverage. Please review.

Project coverage is 47.80%. Comparing base (04afcbe) to head (89082d3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3266 +/- ## ========================================== - Coverage 47.99% 47.80% -0.20% ========================================== Files 1998 1998 Lines 339426 339436 +10 Branches 14905 14859 -46 ========================================== - Hits 162920 162255 -665 - Misses 175658 176794 +1136 + Partials 848 387 -461 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3266?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...c/stores/data-space/DataSpaceQueryBuilderHelper.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3266?src=pr&el=tree&filepath=packages%2Flegend-application-query%2Fsrc%2Fstores%2Fdata-space%2FDataSpaceQueryBuilderHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXF1ZXJ5L3NyYy9zdG9yZXMvZGF0YS1zcGFjZS9EYXRhU3BhY2VRdWVyeUJ1aWxkZXJIZWxwZXIudHM=) | `38.31% <ø> (-0.58%)` | :arrow_down: | | [...-query/src/components/data-space/DataSpaceInfo.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3266?src=pr&el=tree&filepath=packages%2Flegend-application-query%2Fsrc%2Fcomponents%2Fdata-space%2FDataSpaceInfo.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXF1ZXJ5L3NyYy9jb21wb25lbnRzL2RhdGEtc3BhY2UvRGF0YVNwYWNlSW5mby50c3g=) | `21.26% <12.50%> (-2.67%)` | :arrow_down: | ... and [324 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3266/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)