finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
86 stars 113 forks source link

Adds new vscode package #3292

Closed sameersaini closed 2 weeks ago

sameersaini commented 3 weeks ago

This PR adds back package for VS code extension I have tested the prod build of legend-application-studio-deployment. It loads correctly.

Previous error was due to missing path to packages/legend-vscode-extension-dependencies/tsconfig.build.json in rootDir/tsconfig.build.json as seen here https://github.com/finos/legend-studio/pull/3269/files#diff-3ae20d611c1c7263a9c1bce0449291ebfea1c5d578b3fcdbb596353ad885db25

Due to this tscompiler fallback to default dev tsconfig.json.

This has been fixed in this PR. Please see the root tsconfig.build.json

Summary

How did you test this change?

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: f6474e188a6aae93aa7143a934e7e0db8c6f8846

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-vscode-extension-dependencies | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-query | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 109 lines in your changes missing coverage. Please review.

Project coverage is 47.95%. Comparing base (d3d5a73) to head (f6474e1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3292 +/- ## ========================================== + Coverage 47.78% 47.95% +0.16% ========================================== Files 2019 2023 +4 Lines 343384 343493 +109 Branches 10740 14898 +4158 ========================================== + Hits 164093 164724 +631 + Misses 178726 178371 -355 + Partials 565 398 -167 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3292?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...-extension-dependencies/src/graph-manager/index.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3292?src=pr&el=tree&filepath=packages%2Flegend-vscode-extension-dependencies%2Fsrc%2Fgraph-manager%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXZzY29kZS1leHRlbnNpb24tZGVwZW5kZW5jaWVzL3NyYy9ncmFwaC1tYW5hZ2VyL2luZGV4LnRz) | `0.00% <0.00%> (ø)` | | | [.../legend-vscode-extension-dependencies/src/index.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3292?src=pr&el=tree&filepath=packages%2Flegend-vscode-extension-dependencies%2Fsrc%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXZzY29kZS1leHRlbnNpb24tZGVwZW5kZW5jaWVzL3NyYy9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | | | [packages/legend-extension-dsl-diagram/src/index.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3292?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-diagram%2Fsrc%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGlhZ3JhbS9zcmMvaW5kZXgudHM=) | `0.00% <0.00%> (ø)` | | | [...ger/helpers/VSCODE\_Extension\_GraphManagerHelper.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3292?src=pr&el=tree&filepath=packages%2Flegend-vscode-extension-dependencies%2Fsrc%2Fgraph-manager%2Fhelpers%2FVSCODE_Extension_GraphManagerHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXZzY29kZS1leHRlbnNpb24tZGVwZW5kZW5jaWVzL3NyYy9ncmFwaC1tYW5hZ2VyL2hlbHBlcnMvVlNDT0RFX0V4dGVuc2lvbl9HcmFwaE1hbmFnZXJIZWxwZXIudHM=) | `0.00% <0.00%> (ø)` | | ... and [293 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3292/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)