finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
86 stars 113 forks source link

make milestoning param value editable in Query Option #3294

Closed YannanGao-gs closed 2 weeks ago

YannanGao-gs commented 2 weeks ago

Summary

How did you test this change?

https://github.com/finos/legend-studio/assets/73408381/ff1f189d-cd25-4940-bf65-be197dc44b22

Screenshot 2024-06-27 at 10 15 32 AM
changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: c3e3f756f5a004a571da702c9492c647197a88cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-query-builder | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 85.27919% with 29 lines in your changes missing coverage. Please review.

Project coverage is 47.81%. Comparing base (6971c2d) to head (c3e3f75).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3294 +/- ## ========================================== - Coverage 47.83% 47.81% -0.03% ========================================== Files 2019 2019 Lines 343207 343352 +145 Branches 15152 15159 +7 ========================================== - Hits 164185 164181 -4 + Misses 178629 178299 -330 - Partials 393 872 +479 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3294?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...omponents/fetch-structure/QueryBuilderTDSPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3294?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Ffetch-structure%2FQueryBuilderTDSPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvZmV0Y2gtc3RydWN0dXJlL1F1ZXJ5QnVpbGRlclREU1BhbmVsLnRzeA==) | `73.34% <100.00%> (+0.16%)` | :arrow_up: | | [...components/shared/QueryBuilderVariableSelector.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3294?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fshared%2FQueryBuilderVariableSelector.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvc2hhcmVkL1F1ZXJ5QnVpbGRlclZhcmlhYmxlU2VsZWN0b3IudHN4) | `98.28% <100.00%> (+0.02%)` | :arrow_up: | | [...stores/milestoning/QueryBuilderMilestoningState.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3294?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fstores%2Fmilestoning%2FQueryBuilderMilestoningState.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL3N0b3Jlcy9taWxlc3RvbmluZy9RdWVyeUJ1aWxkZXJNaWxlc3RvbmluZ1N0YXRlLnRz) | `75.40% <100.00%> (+0.08%)` | :arrow_up: | | [...xplorer/QueryBuilderMilestoningParameterEditor.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3294?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fexplorer%2FQueryBuilderMilestoningParameterEditor.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvZXhwbG9yZXIvUXVlcnlCdWlsZGVyTWlsZXN0b25pbmdQYXJhbWV0ZXJFZGl0b3IudHN4) | `83.55% <88.33%> (+0.21%)` | :arrow_up: | | [...etch-structure/QueryBuilderResultModifierPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3294?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Ffetch-structure%2FQueryBuilderResultModifierPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvZmV0Y2gtc3RydWN0dXJlL1F1ZXJ5QnVpbGRlclJlc3VsdE1vZGlmaWVyUGFuZWwudHN4) | `86.40% <79.43%> (-0.59%)` | :arrow_down: | ... and [334 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3294/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)