search

finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
86 stars 113 forks source link

minor improvement on about dataspace #3295

Closed YannanGao-gs closed 2 weeks ago

YannanGao-gs commented 2 weeks ago

Summary

minor improvement on about dataspace

BREAKING CHANGE: Update LegendQueryApplicationConfig to contain taxonomyApplicationUrl

How did you test this change?

Screenshot 2024-06-26 at 5 27 43 PM Screenshot 2024-06-26 at 5 11 16 PM

https://github.com/finos/legend-studio/assets/73408381/9425330c-8c47-455f-84c1-45705848aea9

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: ded4b47a021c4e0474bc320062e6878509ae492c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-query-builder | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 37.73585% with 66 lines in your changes missing coverage. Please review.

Project coverage is 47.74%. Comparing base (2dd80ef) to head (ded4b47).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3295 +/- ## ========================================== - Coverage 47.75% 47.74% -0.01% ========================================== Files 2019 2019 Lines 342743 342823 +80 Branches 15121 15109 -12 ========================================== + Hits 163673 163677 +4 + Misses 178505 178274 -231 - Partials 565 872 +307 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3295?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...ry/src/application/LegendQueryApplicationConfig.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3295?src=pr&el=tree&filepath=packages%2Flegend-application-query%2Fsrc%2Fapplication%2FLegendQueryApplicationConfig.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXF1ZXJ5L3NyYy9hcHBsaWNhdGlvbi9MZWdlbmRRdWVyeUFwcGxpY2F0aW9uQ29uZmlnLnRz) | `98.38% <100.00%> (+0.08%)` | :arrow_up: | | [.../\_\_test-utils\_\_/LegendQueryApplicationTestUtils.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3295?src=pr&el=tree&filepath=packages%2Flegend-application-query%2Fsrc%2Fstores%2F__test-utils__%2FLegendQueryApplicationTestUtils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXF1ZXJ5L3NyYy9zdG9yZXMvX190ZXN0LXV0aWxzX18vTGVnZW5kUXVlcnlBcHBsaWNhdGlvblRlc3RVdGlscy50cw==) | `100.00% <100.00%> (ø)` | | | [...c/stores/data-space/DataSpaceQueryBuilderHelper.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3295?src=pr&el=tree&filepath=packages%2Flegend-application-query%2Fsrc%2Fstores%2Fdata-space%2FDataSpaceQueryBuilderHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXF1ZXJ5L3NyYy9zdG9yZXMvZGF0YS1zcGFjZS9EYXRhU3BhY2VRdWVyeUJ1aWxkZXJIZWxwZXIudHM=) | `37.96% <0.00%> (-0.36%)` | :arrow_down: | | [.../src/components/result/QueryBuilderResultPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3295?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fresult%2FQueryBuilderResultPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvcmVzdWx0L1F1ZXJ5QnVpbGRlclJlc3VsdFBhbmVsLnRzeA==) | `66.00% <0.00%> (+0.35%)` | :arrow_up: | | [...c/components/Core\_LegendQueryApplicationPlugin.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3295?src=pr&el=tree&filepath=packages%2Flegend-application-query%2Fsrc%2Fcomponents%2FCore_LegendQueryApplicationPlugin.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXF1ZXJ5L3NyYy9jb21wb25lbnRzL0NvcmVfTGVnZW5kUXVlcnlBcHBsaWNhdGlvblBsdWdpbi50c3g=) | `50.76% <87.50%> (+0.83%)` | :arrow_up: | | [...ication-query/src/\_\_lib\_\_/LegendQueryNavigation.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3295?src=pr&el=tree&filepath=packages%2Flegend-application-query%2Fsrc%2F__lib__%2FLegendQueryNavigation.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXF1ZXJ5L3NyYy9fX2xpYl9fL0xlZ2VuZFF1ZXJ5TmF2aWdhdGlvbi50cw==) | `59.05% <40.00%> (-1.54%)` | :arrow_down: | | [...-query/src/components/data-space/DataSpaceInfo.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3295?src=pr&el=tree&filepath=packages%2Flegend-application-query%2Fsrc%2Fcomponents%2Fdata-space%2FDataSpaceInfo.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXF1ZXJ5L3NyYy9jb21wb25lbnRzL2RhdGEtc3BhY2UvRGF0YVNwYWNlSW5mby50c3g=) | `17.19% <10.71%> (-0.60%)` | :arrow_down: | ... and [164 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3295/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)