finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
86 stars 113 forks source link

Result panel "filter by" produces incorrect list #3309

Closed travisstebbins closed 2 weeks ago

travisstebbins commented 2 weeks ago

Summary

Ag-grid row virtualization caused the "filter by" feature in the result panel to function incorrectly. If the result panel had a large number of rows, and the user selected all the rows in one column and selected "filter by", we wouldn't add all the values to the filter list. This PR fixes that bug.

How did you test this change?

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: dff3e705bcca235b91ba73a1780f17050230a120

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-query-builder | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-vscode-extension-dependencies | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.76%. Comparing base (86c35d7) to head (dff3e70). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3309 +/- ## ======================================= Coverage 47.75% 47.76% ======================================= Files 2023 2023 Lines 343493 343494 +1 Branches 10727 10747 +20 ======================================= + Hits 164038 164065 +27 + Misses 178886 178860 -26 Partials 569 569 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3309?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...omponents/result/tds/QueryBuilderTDSGridResult.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3309?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fresult%2Ftds%2FQueryBuilderTDSGridResult.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvcmVzdWx0L3Rkcy9RdWVyeUJ1aWxkZXJURFNHcmlkUmVzdWx0LnRzeA==) | `14.35% <0.00%> (-0.03%)` | :arrow_down: | ... and [41 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3309/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)