finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 114 forks source link

Fix bugs with post-filter panel and filter by #3328

Closed travisstebbins closed 2 months ago

travisstebbins commented 2 months ago

Summary

Fix bug where deleting a post-filter node and then trying to run "filter by" in the result panel would not create a post-filter node.

Fix bug where selecting a range in the post-filter panel where the cell clicked first is below the cell clicked last would cause "filter by" button to not work.

Adjust styling so that list-editor previews don't take up so much width.

How did you test this change?

Filter panel still functions correctly: FilterPanel

Post-filter panel still functions correctly: PostFilterPanel

Resizing filter panel: ResizingFilterPanel

Resizing post-filter panel: ResizingPostFilterPanel

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: d26b834b9d4285869c13334088d899ca8467b0ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-query-builder | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-dsl-data-quality | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-vscode-extension-dependencies | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.20%. Comparing base (f559f40) to head (d26b834). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3328 +/- ## ========================================== - Coverage 46.39% 46.20% -0.19% ========================================== Files 2083 2084 +1 Lines 355085 356688 +1603 Branches 10826 15222 +4396 ========================================== + Hits 164728 164801 +73 - Misses 189729 191137 +1408 - Partials 628 750 +122 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3328?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...ts/fetch-structure/QueryBuilderPostFilterPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3328?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Ffetch-structure%2FQueryBuilderPostFilterPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvZmV0Y2gtc3RydWN0dXJlL1F1ZXJ5QnVpbGRlclBvc3RGaWx0ZXJQYW5lbC50c3g=) | `83.13% <100.00%> (ø)` | | | [.../src/components/filter/QueryBuilderFilterPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3328?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Ffilter%2FQueryBuilderFilterPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvZmlsdGVyL1F1ZXJ5QnVpbGRlckZpbHRlclBhbmVsLnRzeA==) | `82.85% <100.00%> (ø)` | | | [...omponents/result/tds/QueryBuilderTDSGridResult.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3328?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fresult%2Ftds%2FQueryBuilderTDSGridResult.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvcmVzdWx0L3Rkcy9RdWVyeUJ1aWxkZXJURFNHcmlkUmVzdWx0LnRzeA==) | `14.30% <0.00%> (-0.05%)` | :arrow_down: | ... and [411 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3328/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)