search

finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 114 forks source link

Support use function pointer in curated dataspace template query #3344

Closed YannanGao-gs closed 2 weeks ago

YannanGao-gs commented 2 months ago

Summary

Support use function pointer in curated dataspace template query

Depends on https://github.com/finos/legend-engine/pull/2955

How did you test this change?

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: a9a1339a06e16c44092c39e54e993405eb748524

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-graph | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-repl | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-data-quality | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-lego | Patch | | @finos/legend-query-builder | Patch | | @finos/legend-vscode-extension-dependencies | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 20.84942% with 205 lines in your changes missing coverage. Please review.

Project coverage is 46.17%. Comparing base (8ef5ff9) to head (a9a1339). Report is 94 commits behind head on master.

Files Patch % Lines
.../pure/DSL_DataSpace_PureProtocolProcessorPlugin.ts 10.16% 53 Missing :warning:
...eableElements/dataSpace/DSL_DataSpace_DataSpace.ts 26.19% 29 Missing and 2 partials :warning:
...leElements/dataSpace/V1_DSL_DataSpace_DataSpace.ts 25.00% 25 Missing and 2 partials :warning:
...DataSpaceQueryBuilderTemplateQueryPanelContent.tsx 0.00% 26 Missing :warning:
...mponents/DSL_DataSpace_LegendApplicationPlugin.tsx 0.00% 22 Missing :warning:
...s/data-space/DataSpaceTemplateQueryCreatorStore.ts 22.22% 21 Missing :warning:
...on/pureProtocol/V1_DSL_DataSpace_ProtocolHelper.ts 58.06% 13 Missing :warning:
.../pure/packageableElements/function/SnowflakeApp.ts 16.66% 5 Missing :warning:
...stores/query-builder/DataSpaceQueryBuilderState.ts 0.00% 4 Missing :warning:
...e/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts 33.33% 2 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3344 +/- ## ========================================== + Coverage 46.10% 46.17% +0.06% ========================================== Files 2089 2090 +1 Lines 358279 359084 +805 Branches 14858 14944 +86 ========================================== + Hits 165191 165802 +611 - Misses 192351 192534 +183 - Partials 737 748 +11 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3344?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...sl-data-space/src/graph/DSL\_DataSpace\_HashUtils.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3344?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph%2FDSL_DataSpace_HashUtils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgvRFNMX0RhdGFTcGFjZV9IYXNoVXRpbHMudHM=) | `100.00% <100.00%> (ø)` | | | [...el/packageableElements/function/V1\_SnowflakeApp.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3344?src=pr&el=tree&filepath=packages%2Flegend-graph%2Fsrc%2Fgraph-manager%2Fprotocol%2Fpure%2Fv1%2Fmodel%2FpackageableElements%2Ffunction%2FV1_SnowflakeApp.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWdyYXBoL3NyYy9ncmFwaC1tYW5hZ2VyL3Byb3RvY29sL3B1cmUvdjEvbW9kZWwvcGFja2FnZWFibGVFbGVtZW50cy9mdW5jdGlvbi9WMV9Tbm93Zmxha2VBcHAudHM=) | `49.01% <0.00%> (-0.99%)` | :arrow_down: | | [...e/v1/V1\_DSL\_DataSpace\_PureGraphManagerExtension.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3344?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph-manager%2Fprotocol%2Fpure%2Fv1%2FV1_DSL_DataSpace_PureGraphManagerExtension.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgtbWFuYWdlci9wcm90b2NvbC9wdXJlL3YxL1YxX0RTTF9EYXRhU3BhY2VfUHVyZUdyYXBoTWFuYWdlckV4dGVuc2lvbi50cw==) | `19.07% <33.33%> (+0.09%)` | :arrow_up: | | [...stores/query-builder/DataSpaceQueryBuilderState.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3344?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fstores%2Fquery-builder%2FDataSpaceQueryBuilderState.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvc3RvcmVzL3F1ZXJ5LWJ1aWxkZXIvRGF0YVNwYWNlUXVlcnlCdWlsZGVyU3RhdGUudHM=) | `0.00% <0.00%> (ø)` | | | [.../pure/packageableElements/function/SnowflakeApp.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3344?src=pr&el=tree&filepath=packages%2Flegend-graph%2Fsrc%2Fgraph%2Fmetamodel%2Fpure%2FpackageableElements%2Ffunction%2FSnowflakeApp.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWdyYXBoL3NyYy9ncmFwaC9tZXRhbW9kZWwvcHVyZS9wYWNrYWdlYWJsZUVsZW1lbnRzL2Z1bmN0aW9uL1Nub3dmbGFrZUFwcC50cw==) | `50.00% <16.66%> (-3.85%)` | :arrow_down: | | [...on/pureProtocol/V1\_DSL\_DataSpace\_ProtocolHelper.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3344?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph-manager%2Fprotocol%2Fpure%2Fv1%2Ftransformation%2FpureProtocol%2FV1_DSL_DataSpace_ProtocolHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgtbWFuYWdlci9wcm90b2NvbC9wdXJlL3YxL3RyYW5zZm9ybWF0aW9uL3B1cmVQcm90b2NvbC9WMV9EU0xfRGF0YVNwYWNlX1Byb3RvY29sSGVscGVyLnRz) | `77.91% <58.06%> (-1.54%)` | :arrow_down: | | [...s/data-space/DataSpaceTemplateQueryCreatorStore.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3344?src=pr&el=tree&filepath=packages%2Flegend-application-query%2Fsrc%2Fstores%2Fdata-space%2FDataSpaceTemplateQueryCreatorStore.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uLXF1ZXJ5L3NyYy9zdG9yZXMvZGF0YS1zcGFjZS9EYXRhU3BhY2VUZW1wbGF0ZVF1ZXJ5Q3JlYXRvclN0b3JlLnRz) | `25.00% <22.22%> (-1.52%)` | :arrow_down: | | [...mponents/DSL\_DataSpace\_LegendApplicationPlugin.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3344?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fcomponents%2FDSL_DataSpace_LegendApplicationPlugin.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvY29tcG9uZW50cy9EU0xfRGF0YVNwYWNlX0xlZ2VuZEFwcGxpY2F0aW9uUGx1Z2luLnRzeA==) | `0.00% <0.00%> (ø)` | | | [...DataSpaceQueryBuilderTemplateQueryPanelContent.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3344?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fcomponents%2Fquery-builder%2FDataSpaceQueryBuilderTemplateQueryPanelContent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvY29tcG9uZW50cy9xdWVyeS1idWlsZGVyL0RhdGFTcGFjZVF1ZXJ5QnVpbGRlclRlbXBsYXRlUXVlcnlQYW5lbENvbnRlbnQudHN4) | `0.00% <0.00%> (ø)` | | | [...leElements/dataSpace/V1\_DSL\_DataSpace\_DataSpace.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3344?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph-manager%2Fprotocol%2Fpure%2Fv1%2Fmodel%2FpackageableElements%2FdataSpace%2FV1_DSL_DataSpace_DataSpace.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgtbWFuYWdlci9wcm90b2NvbC9wdXJlL3YxL21vZGVsL3BhY2thZ2VhYmxlRWxlbWVudHMvZGF0YVNwYWNlL1YxX0RTTF9EYXRhU3BhY2VfRGF0YVNwYWNlLnRz) | `59.74% <25.00%> (-6.10%)` | :arrow_down: | | ... and [2 more](https://app.codecov.io/gh/finos/legend-studio/pull/3344?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | | ... and [50 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3344/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)
MauricioUyaguari commented 2 weeks ago

can this be closed ?

YannanGao-gs commented 2 weeks ago

closed by https://github.com/finos/legend-studio/pull/3447