finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 114 forks source link

Form dataspace #3356

Closed Djakhangir closed 1 month ago

Djakhangir commented 1 month ago

This Branch includes new Form implementation with title and description input fields managed using mobx

Summary

How did you test this change?

linux-foundation-easycla[bot] commented 1 month ago

CLA Missing ID CLA Not Signed

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: a9995e9cf0f48132566f323308fc83633a503e04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 5.05618% with 169 lines in your changes missing coverage. Please review.

Project coverage is 46.12%. Comparing base (c39ff29) to head (a9995e9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3356 +/- ## ========================================== - Coverage 46.18% 46.12% -0.07% ========================================== Files 2089 2091 +2 Lines 358147 358323 +176 Branches 10883 15256 +4373 ========================================== - Hits 165415 165261 -154 - Misses 192100 192319 +219 - Partials 632 743 +111 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3356?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...eableElements/dataSpace/DSL\_DataSpace\_DataSpace.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3356?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph%2Fmetamodel%2Fpure%2Fmodel%2FpackageableElements%2FdataSpace%2FDSL_DataSpace_DataSpace.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgvbWV0YW1vZGVsL3B1cmUvbW9kZWwvcGFja2FnZWFibGVFbGVtZW50cy9kYXRhU3BhY2UvRFNMX0RhdGFTcGFjZV9EYXRhU3BhY2UudHM=) | `68.34% <100.00%> (+1.36%)` | :arrow_up: | | [...ts/DSL\_DataSpace\_LegendStudioApplicationPlugin.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3356?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space-studio%2Fsrc%2Fcomponents%2FDSL_DataSpace_LegendStudioApplicationPlugin.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS1zdHVkaW8vc3JjL2NvbXBvbmVudHMvRFNMX0RhdGFTcGFjZV9MZWdlbmRTdHVkaW9BcHBsaWNhdGlvblBsdWdpbi50c3g=) | `0.00% <0.00%> (ø)` | | | [...ta-space-studio/src/stores/DataSpaceEditorState.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3356?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space-studio%2Fsrc%2Fstores%2FDataSpaceEditorState.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS1zdHVkaW8vc3JjL3N0b3Jlcy9EYXRhU3BhY2VFZGl0b3JTdGF0ZS50cw==) | `0.00% <0.00%> (ø)` | | | [...ata-space-studio/src/components/FormTextEditor.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3356?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space-studio%2Fsrc%2Fcomponents%2FFormTextEditor.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS1zdHVkaW8vc3JjL2NvbXBvbmVudHMvRm9ybVRleHRFZGl0b3IudHN4) | `0.00% <0.00%> (ø)` | | ... and [357 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3356/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)