finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 114 forks source link

DataSpace form editor #3358

Closed Djakhangir closed 1 month ago

Djakhangir commented 1 month ago

This changes implement the Form with 2 input fields (title and description) for DataSpace. The Form implemented with Observable helper file, State management and the react component with the actual form.

High-level changes:

Create Form Editor component as DataSpaceEditor with two inputs Add state for DataSpace as DataSpaceEditorState Add DataSpace actions as DSL_DataSpace_GraphModifierHelper i.e., local mode pivot table, check query entitlements Fix styling of Title input field and Description text area

https://github.com/user-attachments/assets/559a3add-c2cb-4f70-b1d8-c5b9e7d32243

https://github.com/user-attachments/assets/d9af10bf-bda9-4282-ba7e-86ab40f628da

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 8678dac67afa3249783a39d579faa9159e1e61a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-query | Patch | | @finos/legend-extension-dsl-data-quality | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

linux-foundation-easycla[bot] commented 1 month ago

CLA Missing ID CLA Not Signed

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0.54945% with 181 lines in your changes missing coverage. Please review.

Project coverage is 46.10%. Comparing base (0796d93) to head (8678dac).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3358 +/- ## ========================================== + Coverage 46.06% 46.10% +0.03% ========================================== Files 2093 2096 +3 Lines 359081 359261 +180 Branches 10888 15325 +4437 ========================================== + Hits 165422 165640 +218 + Misses 193225 192871 -354 - Partials 434 750 +316 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3358?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...on/changeDetection/DSL\_DataSpace\_ObserverHelper.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3358?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph-manager%2Faction%2FchangeDetection%2FDSL_DataSpace_ObserverHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgtbWFuYWdlci9hY3Rpb24vY2hhbmdlRGV0ZWN0aW9uL0RTTF9EYXRhU3BhY2VfT2JzZXJ2ZXJIZWxwZXIudHM=) | `59.57% <33.33%> (-2.65%)` | :arrow_down: | | [...stores/studio/DSL\_DataSpace\_GraphModifierHelper.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3358?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space-studio%2Fsrc%2Fstores%2Fstudio%2FDSL_DataSpace_GraphModifierHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS1zdHVkaW8vc3JjL3N0b3Jlcy9zdHVkaW8vRFNMX0RhdGFTcGFjZV9HcmFwaE1vZGlmaWVySGVscGVyLnRz) | `0.00% <0.00%> (ø)` | | | [...ts/DSL\_DataSpace\_LegendStudioApplicationPlugin.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3358?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space-studio%2Fsrc%2Fcomponents%2FDSL_DataSpace_LegendStudioApplicationPlugin.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS1zdHVkaW8vc3JjL2NvbXBvbmVudHMvRFNMX0RhdGFTcGFjZV9MZWdlbmRTdHVkaW9BcHBsaWNhdGlvblBsdWdpbi50c3g=) | `0.00% <0.00%> (ø)` | | | [...ta-space-studio/src/stores/DataSpaceEditorState.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3358?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space-studio%2Fsrc%2Fstores%2FDataSpaceEditorState.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS1zdHVkaW8vc3JjL3N0b3Jlcy9EYXRhU3BhY2VFZGl0b3JTdGF0ZS50cw==) | `0.00% <0.00%> (ø)` | | | [...ta-space-studio/src/components/DataSpaceEditor.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3358?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space-studio%2Fsrc%2Fcomponents%2FDataSpaceEditor.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS1zdHVkaW8vc3JjL2NvbXBvbmVudHMvRGF0YVNwYWNlRWRpdG9yLnRzeA==) | `0.00% <0.00%> (ø)` | | ... and [165 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3358/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)
MauricioUyaguari commented 1 month ago

Can we add a short screenvideo of how the editor looks like with this two changes ?

MauricioUyaguari commented 1 month ago

Lets also please fix your description for this pull request to describe more what this feature is, same with description.

MauricioUyaguari commented 1 month ago

lets fix the title of the PR!

MauricioUyaguari commented 1 month ago

lets make sure the css aligns with the rest of the elements. could you spend time making it consistent to other editing. please see text or service editor.