Closed Djakhangir closed 1 month ago
Latest commit: 8678dac67afa3249783a39d579faa9159e1e61a3
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Attention: Patch coverage is 0.54945%
with 181 lines
in your changes missing coverage. Please review.
Project coverage is 46.10%. Comparing base (
0796d93
) to head (8678dac
).
Can we add a short screenvideo of how the editor looks like with this two changes ?
Lets also please fix your description for this pull request to describe more what this feature is, same with description.
lets fix the title of the PR!
lets make sure the css aligns with the rest of the elements. could you spend time making it consistent to other editing. please see text or service editor.
This changes implement the Form with 2 input fields (title and description) for DataSpace. The Form implemented with Observable helper file, State management and the react component with the actual form.
High-level changes:
Create Form Editor component as DataSpaceEditor with two inputs Add state for DataSpace as DataSpaceEditorState Add DataSpace actions as DSL_DataSpace_GraphModifierHelper i.e., local mode pivot table, check query entitlements Fix styling of Title input field and Description text area
https://github.com/user-attachments/assets/559a3add-c2cb-4f70-b1d8-c5b9e7d32243
https://github.com/user-attachments/assets/d9af10bf-bda9-4282-ba7e-86ab40f628da