finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 114 forks source link

Add button to copy filter list values #3360

Closed travisstebbins closed 1 month ago

travisstebbins commented 1 month ago

Summary

This PR adds a button to allow users to copy filter list values. Clicking the button will take the tokenized values in the filter list and save it to the user's clipboard as a comma separated list.

It also allows the user to type text into the enum list editor and convert it to an enum item, so that users can paste a list of comma-separated enum values into the editor and have them property converted into a tokenized list.

It also removes the reset button from the list editors since they didn't actually do anything before.

How did you test this change?

String values: StringPrimitiveInstanceValue

Integer values: IntegerPrimitiveInstanceValue

Enum values: EnumInstanceValue

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 3b6a90b84f5b06a8e9e8ac75e5908840dcbb33af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-query-builder | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-dsl-data-quality | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-vscode-extension-dependencies | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 20.23121% with 138 lines in your changes missing coverage. Please review.

Project coverage is 46.06%. Comparing base (f73e8ae) to head (3b6a90b). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3360 +/- ## ========================================== - Coverage 46.18% 46.06% -0.12% ========================================== Files 2089 2089 Lines 358037 358295 +258 Branches 15293 15251 -42 ========================================== - Hits 165346 165055 -291 - Misses 191960 192608 +648 + Partials 731 632 -99 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3360?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...rc/stores/shared/ValueSpecificationEditorHelper.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3360?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fstores%2Fshared%2FValueSpecificationEditorHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL3N0b3Jlcy9zaGFyZWQvVmFsdWVTcGVjaWZpY2F0aW9uRWRpdG9ySGVscGVyLnRz) | `69.07% <50.00%> (-0.27%)` | :arrow_down: | | [...omponents/shared/BasicValueSpecificationEditor.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3360?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fshared%2FBasicValueSpecificationEditor.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvc2hhcmVkL0Jhc2ljVmFsdWVTcGVjaWZpY2F0aW9uRWRpdG9yLnRzeA==) | `79.00% <19.16%> (-6.09%)` | :arrow_down: | ... and [377 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3360/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)