Move query execution error message into query builder result panel, highlight entitlement errors, show no data warning, and show data rounding warning

YannanGao-gs commented 1 month ago

Summary

Move query execution error message into query builder result panel
highlight entitlement errors, show no data warning
show data incompleteness warning
show data rounding warning

How did you test this change?

[ ] Test(s) added
[x] Manual testing (please provide screenshots/recordings)
[ ] No testing (please provide an explanation)

[x] move execution error inside data grid

https://github.com/user-attachments/assets/7b6a5479-b3e9-4a8c-be51-3f3a16759b21

[x] check entitlement highlight

[x] no data warning

[x] data incompleteness warning

[x] data truncate warning

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 9d9d344eb9643f956f030af2d5c09c2d43d091cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages

| Name | Type | | --------------------------------------------- | ----- | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application | Patch | | @finos/legend-query-builder | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-application-repl | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-data-quality | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-lego | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-vscode-extension-dependencies | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 70.33493% with 62 lines in your changes missing coverage. Please review.

Project coverage is 46.17%. Comparing base (35d659f) to head (9d9d344). Report is 6 commits behind head on master.

Files	Patch %	Lines
.../src/components/result/QueryBuilderResultPanel.tsx	74.01%	33 Missing :warning:
...omponents/result/tds/QueryBuilderTDSGridResult.tsx	6.25%	15 Missing :warning:
...gend-application/src/stores/NotificationService.ts	0.00%	14 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #3377 +/- ## ========================================== + Coverage 46.06% 46.17% +0.10% ========================================== Files 2096 2097 +1 Lines 359935 360845 +910 Branches 10940 15528 +4588 ========================================== + Hits 165799 166608 +809 + Misses 193498 193493 -5 - Partials 638 744 +106 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3377?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...d-query-builder/src/\_\_lib\_\_/QueryBuilderTesting.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3377?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2F__lib__%2FQueryBuilderTesting.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL19fbGliX18vUXVlcnlCdWlsZGVyVGVzdGluZy50cw==) | `100.00% <100.00%> (ø)` | | | [...nts/result/tds/QueryBuilderTDSSimpleGridResult.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3377?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fresult%2Ftds%2FQueryBuilderTDSSimpleGridResult.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvcmVzdWx0L3Rkcy9RdWVyeUJ1aWxkZXJURFNTaW1wbGVHcmlkUmVzdWx0LnRzeA==) | `68.21% <100.00%> (+2.60%)` | :arrow_up: | | [...uery-builder/src/stores/QueryBuilderResultState.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3377?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fstores%2FQueryBuilderResultState.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL3N0b3Jlcy9RdWVyeUJ1aWxkZXJSZXN1bHRTdGF0ZS50cw==) | `49.34% <100.00%> (-3.22%)` | :arrow_down: | | [...gend-application/src/stores/NotificationService.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3377?src=pr&el=tree&filepath=packages%2Flegend-application%2Fsrc%2Fstores%2FNotificationService.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWFwcGxpY2F0aW9uL3NyYy9zdG9yZXMvTm90aWZpY2F0aW9uU2VydmljZS50cw==) | `0.00% <0.00%> (ø)` | | | [...omponents/result/tds/QueryBuilderTDSGridResult.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3377?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fresult%2Ftds%2FQueryBuilderTDSGridResult.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvcmVzdWx0L3Rkcy9RdWVyeUJ1aWxkZXJURFNHcmlkUmVzdWx0LnRzeA==) | `14.03% <6.25%> (-0.16%)` | :arrow_down: | | [.../src/components/result/QueryBuilderResultPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3377?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fresult%2FQueryBuilderResultPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvcmVzdWx0L1F1ZXJ5QnVpbGRlclJlc3VsdFBhbmVsLnRzeA==) | `66.53% <74.01%> (+1.33%)` | :arrow_up: | ... and [402 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3377/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)

MauricioUyaguari commented 1 month ago

lets update PR with description of everything that has been updated with regards to the result grid.

YannanGao-gs commented 1 month ago

lets update PR with description of everything that has been updated with regards to the result grid.

Thanks. the changeset has been updated

finos / legend-studio