Closed travisstebbins closed 2 months ago
Latest commit: 7ccefc7a2a9219dce4e8f0374f3eaba552e9f537
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Attention: Patch coverage is 77.77778%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 46.27%. Comparing base (
f3a8062
) to head (7ccefc7
). Report is 3 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
...components/QueryBuilderConstantExpressionPanel.tsx | 0.00% | 2 Missing :warning: |
...y-builder/src/stores/QueryBuilderConstantsState.ts | 87.50% | 2 Missing :warning: |
Summary
This PR fixes a bug with the calculated constant modal. Previously, if the user entered an invalid expression in the calculated constant lambda editor and then clicked the cancel button, an backdrop element would still persist overlayed over the whole UI, making it impossible to interact with the UI.
Also, it optimizes the
cloneQueryBuilderConstantLambdaEditorState
function to make it more performant.How did you test this change?
Example using calculated constant modal: