Closed travisstebbins closed 2 months ago
Latest commit: a7f1ae7a99de08814eff5df0a5283ce9bfe6e615
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 46.29%. Comparing base (
507ce41
) to head (a7f1ae7
). Report is 4 commits behind head on master.
Summary
Improve how we handle when a user changes the type of a constant/parameter/derivation. This PR implements new behavior such that if a user changes the type of a constant/parameter/derivation, if the value is used in the filter or post-filter panels and is no longer compatible, we show it as an error. This ensures users can't change the types of these values and accidentally create an invalid query.
How did you test this change?
Changing const type:
Changing param type:
Changing derivation type when used as post-filter condition left value:
Changing derivation type when used as post-filter condition right value: