finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
89 stars 114 forks source link

resolve an issue where the execution trace ID is not displayed when a query fails to execute #3420

Closed YannanGao-gs closed 2 months ago

YannanGao-gs commented 2 months ago

Summary

resolve an issue where the execution trace ID is not displayed when a query fails to execute

How did you test this change?

image

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: a85053050f8e829eeba0b03d0d1b059e0676528e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-graph | Patch | | @finos/legend-query-builder | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-repl | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-data-quality | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-lego | Patch | | @finos/legend-vscode-extension-dependencies | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 46.32%. Comparing base (830f46b) to head (a850530). Report is 1 commits behind head on master.

Files Patch % Lines
...graph-manager/protocol/pure/v1/engine/V1_Engine.ts 0.00% 8 Missing :warning:
...uery-builder/src/stores/QueryBuilderResultState.ts 50.00% 2 Missing :warning:
...d-graph/src/graph-manager/action/ExecutionError.ts 0.00% 1 Missing :warning:
packages/legend-graph/src/index.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3420 +/- ## ======================================= Coverage 46.31% 46.32% ======================================= Files 2097 2097 Lines 361322 361337 +15 Branches 15251 15212 -39 ======================================= + Hits 167358 167400 +42 + Misses 193526 193501 -25 + Partials 438 436 -2 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3420?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [.../src/components/result/QueryBuilderResultPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3420?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fresult%2FQueryBuilderResultPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvcmVzdWx0L1F1ZXJ5QnVpbGRlclJlc3VsdFBhbmVsLnRzeA==) | `62.82% <100.00%> (+1.03%)` | :arrow_up: | | [...d-graph/src/graph-manager/action/ExecutionError.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3420?src=pr&el=tree&filepath=packages%2Flegend-graph%2Fsrc%2Fgraph-manager%2Faction%2FExecutionError.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWdyYXBoL3NyYy9ncmFwaC1tYW5hZ2VyL2FjdGlvbi9FeGVjdXRpb25FcnJvci50cw==) | `73.07% <0.00%> (-18.93%)` | :arrow_down: | | [packages/legend-graph/src/index.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3420?src=pr&el=tree&filepath=packages%2Flegend-graph%2Fsrc%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWdyYXBoL3NyYy9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | | | [...uery-builder/src/stores/QueryBuilderResultState.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3420?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fstores%2FQueryBuilderResultState.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL3N0b3Jlcy9RdWVyeUJ1aWxkZXJSZXN1bHRTdGF0ZS50cw==) | `55.80% <50.00%> (-0.04%)` | :arrow_down: | | [...graph-manager/protocol/pure/v1/engine/V1\_Engine.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3420?src=pr&el=tree&filepath=packages%2Flegend-graph%2Fsrc%2Fgraph-manager%2Fprotocol%2Fpure%2Fv1%2Fengine%2FV1_Engine.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWdyYXBoL3NyYy9ncmFwaC1tYW5hZ2VyL3Byb3RvY29sL3B1cmUvdjEvZW5naW5lL1YxX0VuZ2luZS50cw==) | `36.66% <0.00%> (-0.21%)` | :arrow_down: | ... and [40 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3420/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)