finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
89 stars 114 forks source link

Enhance the display of error messages in the result grid #3423

Closed YannanGao-gs closed 2 months ago

YannanGao-gs commented 2 months ago

Summary

Enhance the display of error messages in the result grid

How did you test this change?

Screenshot 2024-08-15 at 11 12 21 AM
changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 28e0375ceb02f2476d36ddc0f38939fce4ad8b31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-query-builder | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-dsl-data-quality | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-vscode-extension-dependencies | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 63.15789% with 28 lines in your changes missing coverage. Please review.

Project coverage is 46.23%. Comparing base (d4c6052) to head (28e0375). Report is 4 commits behind head on master.

Files Patch % Lines
.../src/components/result/QueryBuilderResultPanel.tsx 63.15% 28 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3423 +/- ## ========================================== - Coverage 46.24% 46.23% -0.01% ========================================== Files 2097 2097 Lines 361514 361571 +57 Branches 15692 15689 -3 ========================================== Hits 167181 167181 - Misses 193391 193752 +361 + Partials 942 638 -304 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3423?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [.../src/components/result/QueryBuilderResultPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3423?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fresult%2FQueryBuilderResultPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvcmVzdWx0L1F1ZXJ5QnVpbGRlclJlc3VsdFBhbmVsLnRzeA==) | `61.19% <63.15%> (-1.64%)` | :arrow_down: | ... and [161 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3423/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)