finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 114 forks source link

Revert "Improve handling of changing const/param/derivation types" #3433

Closed travisstebbins closed 4 weeks ago

travisstebbins commented 4 weeks ago

This reverts https://github.com/finos/legend-studio/pull/3414 (commit ca421ff1b2484762a2443446dfe8aa70973c48ef)

Summary

How did you test this change?

Before change: BeforeChange

After change: AfterChange

changeset-bot[bot] commented 4 weeks ago

🦋 Changeset detected

Latest commit: 3112ed457cbed79ba43322b3567968c5a7767091

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-query-builder | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-dsl-data-quality | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-vscode-extension-dependencies | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.31%. Comparing base (e0365b4) to head (3112ed4). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3433 +/- ## ========================================== - Coverage 46.40% 46.31% -0.10% ========================================== Files 2097 2097 Lines 361581 361504 -77 Branches 15760 15657 -103 ========================================== - Hits 167794 167423 -371 - Misses 192892 193135 +243 - Partials 895 946 +51 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3433?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...ts/fetch-structure/QueryBuilderPostFilterPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3433?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Ffetch-structure%2FQueryBuilderPostFilterPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvZmV0Y2gtc3RydWN0dXJlL1F1ZXJ5QnVpbGRlclBvc3RGaWx0ZXJQYW5lbC50c3g=) | `84.01% <100.00%> (-0.29%)` | :arrow_down: | | [...omponents/fetch-structure/QueryBuilderTDSPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3433?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Ffetch-structure%2FQueryBuilderTDSPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvZmV0Y2gtc3RydWN0dXJlL1F1ZXJ5QnVpbGRlclREU1BhbmVsLnRzeA==) | `74.06% <100.00%> (-0.66%)` | :arrow_down: | | [.../src/components/filter/QueryBuilderFilterPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3433?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Ffilter%2FQueryBuilderFilterPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvZmlsdGVyL1F1ZXJ5QnVpbGRlckZpbHRlclBhbmVsLnRzeA==) | `89.89% <100.00%> (-0.05%)` | :arrow_down: | | [...src/stores/QueryBuilderValueSpecificationHelper.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3433?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fstores%2FQueryBuilderValueSpecificationHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL3N0b3Jlcy9RdWVyeUJ1aWxkZXJWYWx1ZVNwZWNpZmljYXRpb25IZWxwZXIudHM=) | `84.96% <100.00%> (-0.04%)` | :arrow_down: | | [...ure/tds/post-filter/QueryBuilderPostFilterState.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3433?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fstores%2Ffetch-structure%2Ftds%2Fpost-filter%2FQueryBuilderPostFilterState.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL3N0b3Jlcy9mZXRjaC1zdHJ1Y3R1cmUvdGRzL3Bvc3QtZmlsdGVyL1F1ZXJ5QnVpbGRlclBvc3RGaWx0ZXJTdGF0ZS50cw==) | `77.40% <100.00%> (-0.60%)` | :arrow_down: | | [...ilder/src/stores/filter/QueryBuilderFilterState.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3433?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fstores%2Ffilter%2FQueryBuilderFilterState.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL3N0b3Jlcy9maWx0ZXIvUXVlcnlCdWlsZGVyRmlsdGVyU3RhdGUudHM=) | `89.39% <100.00%> (-0.07%)` | :arrow_down: | ... and [88 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3433/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)