finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 114 forks source link

Add an engine round trip test for previewing data #3441

Closed YannanGao-gs closed 3 weeks ago

YannanGao-gs commented 3 weeks ago

Summary

Add an engine round trip test for previewing data

How did you test this change?

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 366e44634b2a869d032305c9ed06da7588d995e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-query-builder | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-dsl-data-quality | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-vscode-extension-dependencies | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 53.33333% with 28 lines in your changes missing coverage. Please review.

Project coverage is 46.36%. Comparing base (37ec5ed) to head (366e446). Report is 6 commits behind head on master.

Files Patch % Lines
.../components/explorer/QueryBuilderExplorerPanel.tsx 51.72% 28 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3441 +/- ## ========================================== + Coverage 46.28% 46.36% +0.07% ========================================== Files 2097 2098 +1 Lines 361575 361561 -14 Branches 15268 10844 -4424 ========================================== + Hits 167370 167636 +266 - Misses 193471 193489 +18 + Partials 734 436 -298 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3441?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...d-query-builder/src/\_\_lib\_\_/QueryBuilderTesting.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3441?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2F__lib__%2FQueryBuilderTesting.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL19fbGliX18vUXVlcnlCdWlsZGVyVGVzdGluZy50cw==) | `100.00% <100.00%> (ø)` | | | [.../components/explorer/QueryBuilderExplorerPanel.tsx](https://app.codecov.io/gh/finos/legend-studio/pull/3441?src=pr&el=tree&filepath=packages%2Flegend-query-builder%2Fsrc%2Fcomponents%2Fexplorer%2FQueryBuilderExplorerPanel.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLXF1ZXJ5LWJ1aWxkZXIvc3JjL2NvbXBvbmVudHMvZXhwbG9yZXIvUXVlcnlCdWlsZGVyRXhwbG9yZXJQYW5lbC50c3g=) | `90.52% <51.72%> (-0.07%)` | :arrow_down: | ... and [190 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3441/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)