search

finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 114 forks source link

Refactor data space executable to support use function pointer #3447

Closed YannanGao-gs closed 3 weeks ago

YannanGao-gs commented 3 weeks ago

Summary

Refactor data space executable to support use function pointer

How did you test this change?

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 90c502fc9749ca1becd2ec1e1462f42e83e8900d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-dsl-data-quality | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 13.04348% with 140 lines in your changes missing coverage. Please review.

Project coverage is 46.29%. Comparing base (904888a) to head (90c502f). Report is 3 commits behind head on master.

Files Patch % Lines
.../pure/DSL_DataSpace_PureProtocolProcessorPlugin.ts 2.73% 71 Missing :warning:
...l/pure/v1/engine/analytics/V1_DataSpaceAnalysis.ts 35.48% 20 Missing :warning:
...stores/query-builder/DataSpaceQueryBuilderState.ts 0.00% 16 Missing :warning:
...eableElements/dataSpace/DSL_DataSpace_DataSpace.ts 13.33% 13 Missing :warning:
...e/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts 16.66% 10 Missing :warning:
...leElements/dataSpace/V1_DSL_DataSpace_DataSpace.ts 0.00% 6 Missing :warning:
...raph-manager/action/analytics/DataSpaceAnalysis.ts 33.33% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3447 +/- ## ========================================== - Coverage 46.34% 46.29% -0.05% ========================================== Files 2098 2098 Lines 361546 361686 +140 Branches 11251 11233 -18 ========================================== - Hits 167550 167454 -96 - Misses 193356 193594 +238 + Partials 640 638 -2 ``` | [Files](https://app.codecov.io/gh/finos/legend-studio/pull/3447?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos) | Coverage Δ | | |---|---|---| | [...on/pureProtocol/V1\_DSL\_DataSpace\_ProtocolHelper.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3447?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph-manager%2Fprotocol%2Fpure%2Fv1%2Ftransformation%2FpureProtocol%2FV1_DSL_DataSpace_ProtocolHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgtbWFuYWdlci9wcm90b2NvbC9wdXJlL3YxL3RyYW5zZm9ybWF0aW9uL3B1cmVQcm90b2NvbC9WMV9EU0xfRGF0YVNwYWNlX1Byb3RvY29sSGVscGVyLnRz) | `79.59% <100.00%> (+0.13%)` | :arrow_up: | | [...raph-manager/action/analytics/DataSpaceAnalysis.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3447?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph-manager%2Faction%2Fanalytics%2FDataSpaceAnalysis.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgtbWFuYWdlci9hY3Rpb24vYW5hbHl0aWNzL0RhdGFTcGFjZUFuYWx5c2lzLnRz) | `32.42% <33.33%> (+0.02%)` | :arrow_up: | | [...leElements/dataSpace/V1\_DSL\_DataSpace\_DataSpace.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3447?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph-manager%2Fprotocol%2Fpure%2Fv1%2Fmodel%2FpackageableElements%2FdataSpace%2FV1_DSL_DataSpace_DataSpace.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgtbWFuYWdlci9wcm90b2NvbC9wdXJlL3YxL21vZGVsL3BhY2thZ2VhYmxlRWxlbWVudHMvZGF0YVNwYWNlL1YxX0RTTF9EYXRhU3BhY2VfRGF0YVNwYWNlLnRz) | `64.56% <0.00%> (-1.28%)` | :arrow_down: | | [...e/v1/V1\_DSL\_DataSpace\_PureGraphManagerExtension.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3447?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph-manager%2Fprotocol%2Fpure%2Fv1%2FV1_DSL_DataSpace_PureGraphManagerExtension.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgtbWFuYWdlci9wcm90b2NvbC9wdXJlL3YxL1YxX0RTTF9EYXRhU3BhY2VfUHVyZUdyYXBoTWFuYWdlckV4dGVuc2lvbi50cw==) | `18.93% <16.66%> (-0.05%)` | :arrow_down: | | [...eableElements/dataSpace/DSL\_DataSpace\_DataSpace.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3447?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph%2Fmetamodel%2Fpure%2Fmodel%2FpackageableElements%2FdataSpace%2FDSL_DataSpace_DataSpace.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgvbWV0YW1vZGVsL3B1cmUvbW9kZWwvcGFja2FnZWFibGVFbGVtZW50cy9kYXRhU3BhY2UvRFNMX0RhdGFTcGFjZV9EYXRhU3BhY2UudHM=) | `64.25% <13.33%> (-2.74%)` | :arrow_down: | | [...stores/query-builder/DataSpaceQueryBuilderState.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3447?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fstores%2Fquery-builder%2FDataSpaceQueryBuilderState.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvc3RvcmVzL3F1ZXJ5LWJ1aWxkZXIvRGF0YVNwYWNlUXVlcnlCdWlsZGVyU3RhdGUudHM=) | `0.00% <0.00%> (ø)` | | | [...l/pure/v1/engine/analytics/V1\_DataSpaceAnalysis.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3447?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph-manager%2Fprotocol%2Fpure%2Fv1%2Fengine%2Fanalytics%2FV1_DataSpaceAnalysis.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgtbWFuYWdlci9wcm90b2NvbC9wdXJlL3YxL2VuZ2luZS9hbmFseXRpY3MvVjFfRGF0YVNwYWNlQW5hbHlzaXMudHM=) | `26.60% <35.48%> (+0.49%)` | :arrow_up: | | [.../pure/DSL\_DataSpace\_PureProtocolProcessorPlugin.ts](https://app.codecov.io/gh/finos/legend-studio/pull/3447?src=pr&el=tree&filepath=packages%2Flegend-extension-dsl-data-space%2Fsrc%2Fgraph-manager%2Fprotocol%2Fpure%2FDSL_DataSpace_PureProtocolProcessorPlugin.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos#diff-cGFja2FnZXMvbGVnZW5kLWV4dGVuc2lvbi1kc2wtZGF0YS1zcGFjZS9zcmMvZ3JhcGgtbWFuYWdlci9wcm90b2NvbC9wdXJlL0RTTF9EYXRhU3BhY2VfUHVyZVByb3RvY29sUHJvY2Vzc29yUGx1Z2luLnRz) | `59.35% <2.73%> (-5.43%)` | :arrow_down: | ... and [56 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3447/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)