finos / legend-studio

Legend Studio
https://legend.finos.org
Apache License 2.0
87 stars 114 forks source link

Fix DND property to calendar aggregation function #3451

Closed travisstebbins closed 3 weeks ago

travisstebbins commented 3 weeks ago

Summary

This PR fixes a bug where users are unable to DND a property from the explorer panel to a calendar aggregation function. The bug was introduced here (https://github.com/finos/legend-studio/pull/3185) because allowing the user to DND to the entire fetch structure panel blocked DND onto a calendar aggregation function.

How did you test this change?

DND property to calendar aggregation function: DNDCalendarAggregation

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: c688558f26f803805c332aa58fe36320b55fc0ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages | Name | Type | | --------------------------------------------- | ----- | | @finos/legend-query-builder | Patch | | @finos/legend-application-query | Patch | | @finos/legend-application-studio | Patch | | @finos/legend-extension-dsl-data-quality | Patch | | @finos/legend-extension-dsl-data-space-studio | Patch | | @finos/legend-extension-dsl-data-space | Patch | | @finos/legend-extension-dsl-service | Patch | | @finos/legend-application-query-bootstrap | Patch | | @finos/legend-application-studio-bootstrap | Patch | | @finos/legend-extension-assortment | Patch | | @finos/legend-extension-dsl-diagram | Patch | | @finos/legend-extension-dsl-persistence | Patch | | @finos/legend-extension-dsl-text | Patch | | @finos/legend-extension-store-flat-data | Patch | | @finos/legend-extension-store-relational | Patch | | @finos/legend-extension-store-service-store | Patch | | @finos/legend-vscode-extension-dependencies | Patch | | @finos/legend-application-query-deployment | Patch | | @finos/legend-application-studio-deployment | Patch | | @finos/legend-application-pure-ide | Patch | | @finos/legend-application-pure-ide-deployment | Patch | | @finos/legend-application-repl-deployment | Patch | | @finos/legend-server-showcase-deployment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.27%. Comparing base (085d9c5) to head (c688558). Report is 9 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3451 +/- ## ========================================== + Coverage 46.24% 46.27% +0.03% ========================================== Files 2098 2098 Lines 361561 361686 +125 Branches 10777 11183 +406 ========================================== + Hits 167190 167363 +173 + Misses 193935 193685 -250 - Partials 436 638 +202 ``` [see 263 files with indirect coverage changes](https://app.codecov.io/gh/finos/legend-studio/pull/3451/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=finos)