search

finos / messageml-utils

MessageML is a markup language used by the Symphony Agent API for representing messages, including formatting (bold, italic, numbered and unnumbered lists etc.) and entity data representing structured objects.
https://docs.developers.symphony.com
Apache License 2.0
12 stars 28 forks source link

MML-265 Fill BiContext with MessageML simple tags attributes #266

Closed symphony-mariacristina closed 3 years ago

symphony-mariacristina commented 3 years ago

After this implementation #259 we are ready to start filling the BiContext with a list BiItems. This PR will take care of all the simple tags elements such as headers, paragraphs, link. Most of the cases for these elements we want to compute the number of occurrences of the elements it self or in some cases the max value found inside the message (like for TableColumnsMax). Also we are going to add general BI to compute MessageLength, FreeMarkerUse, EntityJSONSize and usage of Styles and Custom css.

Each one of this BiItem is following the same format. Since for them we are only going to store a single attribute in the map, each item has a specific name and a map with only "count" attribute.

Closes #265 #268

thibauult commented 3 years ago

We might want to remove codeclimate integration. WDYT guys?

symphony-youri commented 3 years ago

We might want to remove codeclimate integration. WDYT guys?

For now it was used as a replacement for Sonar (which we could get by moving to Finos), it is not preventing the merge I think, more of something to check before merging. Since it is there and working I would perhaps keep it (but no strong opinion on that really).