search

finos / messageml-utils

MessageML is a markup language used by the Symphony Agent API for representing messages, including formatting (bold, italic, numbered and unnumbered lists etc.) and entity data representing structured objects.
https://docs.developers.symphony.com
Apache License 2.0
12 stars 28 forks source link

Avoid Freemarker warning in logs #276

Closed symphony-youri closed 3 years ago

symphony-youri commented 3 years ago

Freemarker now logs a warning when Configuration.getVersion() is used, a specific version should be used instead.

See https://freemarker.apache.org/docs/pgui_config_incompatible_improvements.html

Use the current version that we get as a dependency (that what is returned by getVersion() now).

symphony-mariacristina commented 3 years ago

maybe we can add a comment in the pom where the freemarker version is specified to remember to update also this one if we update the pom? wdyt?

symphony-youri commented 3 years ago

maybe we can add a comment in the pom where the freemarker version is specified to remember to update also this one if we update the pom? wdyt?

my understanding is that we might not want to because it could change the behavior for existing templates (i'm not sure we have this kind of problems), I would perhaps do it on a per need basis

symphony-mariacristina commented 3 years ago

my understanding is that we might not want to because it could change the behavior for existing templates (i'm not sure we have this kind of problems), I would perhaps do it on a per need basis

ok got it, It makes sense! I'm ok then to keep it like this! :)