finos / messageml-utils

MessageML is a markup language used by the Symphony Agent API for representing messages, including formatting (bold, italic, numbered and unnumbered lists etc.) and entity data representing structured objects.
https://docs.developers.symphony.com
Apache License 2.0
12 stars 28 forks source link

Adding Bi Items for Custom entities #334

Closed symphony-mariacristina closed 2 years ago

symphony-mariacristina commented 2 years ago

Goal of this implementation is to add BiItems in the BiContext for custom entities as well. For each custom entity found in the entityJson payload we

:white_check_mark: Checklist

symphony-mariacristina commented 2 years ago

If I understand correctly we can have custom entities and custom sub entities (nested), do we need to know about them in the BI context?

From the specs we only care about the type of entity used

And just a thought (probably out of scope), do we validate custom entity types? (like the format, length) or can we pass super long values and therefore put a lot of data into the BI system?

Nope, seems like we are not enforcing any limitation on the custom entity type fields