finos / metadata-tool

A command line tool for performing various tasks with Fintech Open Source Foundation (FINOS) metadata.
Apache License 2.0
12 stars 5 forks source link

Initial cleanup with static analysis tools: whitespace, idiom, deleting unused items #42

Closed tschady closed 5 years ago

tschady commented 5 years ago

Many changes here using static analysis tools to find style and linting errors (kibit, eastwood, cljfmt) to conform to community standards.

It might be easiest to review each commit in turn, since the first one changes almost every line (whitespace corrections according to bbatsov's community style guide).

maoo commented 5 years ago

This is great @tschady , thanks a lot!

I've rebased the PR against the dev branch, but I see a conflict that I'm not 100% sure how to resolve; could you please have a look at it?

Also, I wonder how we can prevent linting issues in the future; I believe that Travis builds should fail, if linting is broken; do you know how we can update our .travis.yml accordingly?

TY!

tschady commented 5 years ago

@maoo I cannot easily resolve the conflict as I don't have write perms, but the only diff is version number bumps in dev branch. Updating those will resolve. Want to give it a try? I'll work off dev for the future.

tschady commented 5 years ago

Also, I wonder how we can prevent linting issues in the future; I believe that Travis builds should fail, if linting is broken; do you know how we can update our .travis.yml accordingly?

Added #43

maoo commented 5 years ago

LGTM, merging.