search

finos / metadata-tool

A command line tool for performing various tasks with Fintech Open Source Foundation (FINOS) metadata.
Apache License 2.0
12 stars 5 forks source link

Confluence selenium crawler #45

Closed maoo closed 4 years ago

maoo commented 4 years ago

This code uses Selenium to pull meeting attendance data from FINOS public Wiki pages (hosted on https://finosfoundation.atlassian.net/wiki and publicly accessible).

The PR also updates documentation on how to run metadata-tool locally.

maoo commented 4 years ago

Without tests, I'd be hesitant to remove the nil-checks everywhere, but I think there's ways to do so that make the code a lot clearer. Cool, thanks for adding me as a reviewer.

I think you're right @tschady , we should work on adding tests first. Would you like to propose a PR against the confluence-selenium-crawler branch? Doesn't have to fully cover all the crawling feature, let's start from the simplest ones, ie parse-string.

maoo commented 4 years ago

Regardless of testing, which is an aspect of this codebase that needs much more time allocation, I think this PR is ready to be merged into dev.