search

finos / morphir-elm

Tools to work with the Morphir IR in Elm.
https://package.elm-lang.org/packages/finos/morphir-elm/latest
Apache License 2.0
46 stars 65 forks source link

morphir Char sdk includes toLocaleUpper and toLocaleLower #1151

Open edwardpeters opened 8 months ago

edwardpeters commented 8 months ago

Describe the bug The morphir SDK for Char includes a pair of functions toLocaleUpper and toLocalLower. These appear to rely on system-dependent settings, and are not appropriate for the pure functional nature of Morphir. They appear to have been copied from elm-core.

These functions should either be removed, or modified to take the Locale as a parameter. References to them may be found in https://github.com/finos/morphir-elm/blob/main/src/Morphir/IR/SDK/Char.elm and few other morphir-elm files.